Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Don't Refuse to Start if Add-On Manifest is Missing #7686

Closed
elliott94 opened this issue Oct 23, 2017 · 13 comments

Comments

@elliott94
Copy link

commented Oct 23, 2017

STR:

  1. Download the OCR add-on, and install using the Add-Ons Manager.
  2. Restart NVDA with all add-ons disabled, and remove everything within the "ocr" directory (but not the directory itself) from within the "nvda" data directory.
  3. Restart NVDA; you should note that it refuses to launch, and outputs something like the following in the log:
INFO - __main__ (13:35:20.844):
Starting NVDA
INFO - core.main (13:35:21.078):
Config dir: C:\Users\Username\AppData\Roaming\nvda
INFO - config.ConfigManager._loadConfig (13:35:21.078):
Loading config: C:\Users\Username\AppData\Roaming\nvda\nvda.ini
INFO - core.main (13:35:21.128):
NVDA version next-14528,b476430a
INFO - core.main (13:35:21.128):
Using Windows version 10.0.15063 workstation
INFO - core.main (13:35:21.128):
Using Python version 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:42:59) [MSC v.1500 32 bit (Intel)]
INFO - core.main (13:35:21.128):
Using comtypes version 0.6.2
CRITICAL - __main__ (13:35:21.134):
core failure
Traceback (most recent call last):
  File "nvda.pyw", line 202, in <module>
  File "core.pyc", line 202, in main
  File "addonHandler.pyc", line 124, in initialize
  File "addonHandler.pyc", line 74, in completePendingAddonRemoves
  File "addonHandler.pyc", line 215, in __init__
IOError: [Errno 2] No such file or directory: u'C:\\Users\\Username\\AppData\\Roaming\\nvda\\addons\\ocr\\manifest.ini'
@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Oct 24, 2017

Though it is quite an unusual and unsupported way to destroy an add-on this way, it is indeed quite drastic and probably not very difficult to fix. I'd suggest a p3.

@josephsl

This comment has been minimized.

Copy link
Collaborator

commented Oct 24, 2017

@Brian1Gaff

This comment has been minimized.

Copy link

commented Oct 24, 2017

@elliott94

This comment has been minimized.

Copy link
Author

commented Oct 24, 2017

This actually occurred after removing an add-on via the Add-Ons Manager, but for whatever reason the main directory wasn't removed at which point I received the error detailed in the issue description.

@feerrenrut

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2017

I agree with P3. One thing that is probably worth thinking about, is how resolving this will impact an add-on developer. One thing that is good about the current behaviour, is that it's clear that there is a problem.

@awalvie

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

What is a p3 ?

@josephsl

This comment has been minimized.

Copy link
Collaborator

commented Mar 10, 2019

@awalvie

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

Oh gotcha thanks.

@lukaszgo1

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

@awalvie Have you tried to reproduce the issue before writing a fix? I am asking, because for me when performing STR from the initial commend with latest NVDA Alpha the bug isn't occurring anymore.

@awalvie

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Yeah the issue still exists for me and was replicated after following the instructions of the issue. Though I have been testing on the Master Branch and not on the Alpha

@bdorer

This comment has been minimized.

Copy link

commented Mar 19, 2019

@awalvie

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

I have'nt tested this for the Alpha Build but on the current main branch I can still replicate the issue.

@feerrenrut

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

I have'nt tested this for the Alpha Build but on the current main branch I can still replicate the issue.

Alpha builds are built from the master branch.

@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Mar 27, 2019

feerrenrut added a commit that referenced this issue Mar 27, 2019

Avoid crash if addon directory is empty. (PR #9372)
Fixes #7686

Added a condition that gives an error in the log file if the Directory is empty.
Now writes to the log file in case of failing the condition check

@michaelDCurran michaelDCurran modified the milestones: 2019.1, 2019.2 Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.