New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running NVDA from launcher could invalidate user config for past installation #7688

Closed
feerrenrut opened this Issue Oct 24, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@feerrenrut
Contributor

feerrenrut commented Oct 24, 2017

I haven't tested this with exact versions, so this is a bit theoretical at this point. However I'm fairly confident this could cause some hard to notice / track down issues.

Steps to reproduce:

  1. Install an older release, EG 2017.2
  2. Reset user config to factory defaults, to ensure that the config schema is for 2017.2
  3. Open the NVDA config file, and take note of the schema version
  4. Run from the launcher of a newer release EG 2017.3
  5. Don't install the newer release, decide to continue using the already installed older release.
  6. Check the config schema version

Expected behavior:

The config file should remain as it was in the 2017.2 install, and not be affected by running from the launcher.
This goes for voice dictionary files as well.

Actual behavior:

Its likely that the config files get upgraded to the new schema. These changes are not necessarily backwards compatible, and might result in certain settings mysteriously different after running from the launcher. One example is the braille display cursor blink rate.
Moving the voice dictionary files could result in these files not being available anymore in the older install.

@feerrenrut feerrenrut added bug p2 labels Oct 24, 2017

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Oct 24, 2017

Contributor

One option to address this might be for the launcher to run NVDA with securemode stopping NVDA from having write access to the users config directory.

Contributor

feerrenrut commented Oct 24, 2017

One option to address this might be for the launcher to run NVDA with securemode stopping NVDA from having write access to the users config directory.

feerrenrut added a commit that referenced this issue Oct 25, 2017

Dont upgrade conf when not installed
When running from the launcher, dont upgrade NVDA config or move espeak
voice dictionaries. Fixes #7688

@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Nov 1, 2017

@feerrenrut feerrenrut closed this in d63f4ed Nov 1, 2017

feerrenrut added a commit that referenced this issue Nov 1, 2017

Update changes file for PR #7666
- Voice dictionary files are now versioned and have been moved to the
  'speechDicts/voiceDicts.v1' directory. (#7592)
- Versioned files (user configuration, voice dictionaries)
  modifications are no longer saved when NVDA is run from the launcher.
  (#7688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment