Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alva satellite used via protocol converter and Optelec BC6 driver does not detect some keys and some keys were assigned twice #8074

Closed
gregjozk opened this issue Mar 10, 2018 · 11 comments · Fixed by #8230

Comments

@gregjozk
Copy link
Contributor

First of all I would like to thank all of you to bring support for protocol converter into NVDA.

Here is one problem: Alva Satellite has 2 Satellite keypads, one on the leftside of display and one on the rightside with 6 keys on the each keypads, but NVDA treats them as one keypad. I do not know if it is bug of NVDA or bug of protocol converter, so I have opened this ticket as @LeonarddeR suggested in private conversation.

Steps to reproduce:

  1. connect Alva Satellite to computer via protocol converter
  2. wait system to install it on the system if it was not installed already
  3. from the braille settings choose Optelec bc6...
  4. turn input help on
  5. play with keys on Satellite display

Expected behavior:

NVDA should differentiate between Satellite keypads, so NVDA could emulates most of keys which are on bc6 displays.

Actual behavior:

Now NVDA emulates: sp1, sp4, and sp left, right, up and down on both satellite keypads. So there are not: sp2, sp3, spEnter, etouch1, etouch3 and etouch4.

System configuration:

NVDA version:

next: 14941,891a9c9e

NVDA Installed or portable:
installed

Other information:

Windows version:

Windows 10Ver1709 (64-bit) build 16299.248

Other questions:

Does the issue still occur after restarting your PC?
yes

Have you tried any other versions of NVDA?
no

@LeonarddeR
Copy link
Collaborator

I believe this can be fixed by differentiating between two smart pads. An ALVA BC680 is basically a device with two BC640 devices in one.

@dkager: would be good to have your opinion about this.

@dkager dkager changed the title optelec bc6 (when used as Alva satellite via protocol converter) does not detect some keys and some keys were assigned twice Alva satellite used via protocol converter and Optelec BC6 driver does not detect some keys and some keys were assigned twice Mar 10, 2018
@dkager
Copy link
Collaborator

dkager commented Mar 10, 2018

I don't think the BC680 differentiates between the two keypads in its own driver nor in the user guide. So that would explain this issue. We should find out if the protocol converter indicates which keypad was used, e.g. in a way similar to how the secondary routing keys are sent. If the converter does not distinguish two keypads, I'm afraid there is not much we can do.

@dkager
Copy link
Collaborator

dkager commented Mar 10, 2018

OK, so it turns out the driver distinguishes the thumb keys and the smartpad keys on the BC680 and probably also the protocol converter. But they get the same name, so you have two sp1 and two spEnter, etc. Now the question is what name do we give the second group instead. As I said, Optelec appears to see them as duplicates. For the protocol converter it would make more sense to give them other names. Then we might as well give them different names for the BC680 too.

@LeonarddeR Suggestions? I think 2ndSp1 is a bit awkward and sp5-sp8 are confusing because Optelec's user guide doesn't mention them.

@gregjozk
Copy link
Contributor Author

gregjozk commented Mar 10, 2018

Hello,

Now the question is what name do we give the second group instead.

I suggest that the second group of satellite keys could emulate sp2, sp3, spEnter, etouch1, 2 and 3, because these buttons could not be emulated now.
In the NVDA UG it could be documented with one or two rows; e.g.: At Alva Satellite series, when these displays have been used with protocol converter, one group is linked to arrow keys and tab and shift+tab command, the other keypad is linked to sp2, sp3, spEnter and etouch1, etouch3 and etouch4, due to specifics of protocol converter.
for bc680 I did not see a problem. Would a correction break existing support?

thx.

@dkager
Copy link
Collaborator

dkager commented Mar 11, 2018

I think it makes sense if you can also assign different commands to either smartpad on the BC680. That means we have to come up with different names for the second smartpad.

Note that the converter should not emulate sp3 and sp4, but should execute the associated scripts. We could have a model-specific gesture map for the converter.

@gregjozk
Copy link
Contributor Author

gregjozk commented Mar 11, 2018 via email

@dkager
Copy link
Collaborator

dkager commented Mar 11, 2018

Could you post a link to the manual? If not, maybe upload it to GitHub.

To clarify, are you saying the status cells are not working, but the secondary routing keys are working?

@gregjozk
Copy link
Contributor Author

Hello,

yes, secondary routing is working as expected.

a manual and other material I plan to send via contact form on your website if it is ok for you.

@gregjozk
Copy link
Contributor Author

gregjozk commented May 3, 2018

Hello,

thanks for your work.
I've just tested it with try build, which was linked to #8230, but I don't see any changes. NVDA steal treats both satellite keypads as one.

regards, Jožef

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented May 4, 2018 via email

@gregjozk
Copy link
Contributor Author

gregjozk commented May 4, 2018 via email

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants