Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 build 17120: OneCore voices sound as though high-pitch effect was put on them #8082

Closed
josephsl opened this issue Mar 13, 2018 · 9 comments
Assignees
Milestone

Comments

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Mar 13, 2018

Hi,

This is considered a critical showstopper: Windows OneCore voices sound a bit different, in that it looks like high0pitch effect was put on them.

STR:

  1. Install Windows 10 build 17120 (Insider Fast).
  2. Switch to Windows OneCore voices.

Expected: pitch stays the same.
Actual: you'll notice the effects.
Additional: this does not happen with JAWS and Narrator.

Thanks.

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Mar 13, 2018

@josephsl
Copy link
Collaborator Author

@josephsl josephsl commented Mar 14, 2018

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Mar 14, 2018

Could this have to do with NVDA not yet using the most recent OneCore speech API that also supports faster speech rates?

In any case, confirmed here as well.

@Qchristensen
Copy link
Member

@Qchristensen Qchristensen commented Mar 14, 2018

Ditto here, the only thing I'd add is just to document:

  • The speech rate is faster than it was previously. EG I had previously set the rate in Windows' speech settings as fast as possible and NVDA's to about the middle. If I now set the Windows speech rate to the middle, the rate is similar.
  • The pitch is also much higher than previously. There is no option in Windows (that I have found, unless there's a registry key or something?) to change pitch. Changing NVDA's pitch has a minimal effect.

Neither restarting NVDA or the computer, or changing synthesizers to something else and back changes the behaviour.

Interestingly with the sample rate theory, I tried recording the audio with the "Voice recorder" app by Microsoft from the Windows store, and the recording came out sounding like a chipmunk, so it seems they have changed sample rates and not adjusted even across their own apps.

I made a recording on my phone illustrating the new behaviour which I've uploaded here: https://www.dropbox.com/s/zmfn27sn5twml2j/My%20recording%20%234.wav?dl=0

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Mar 14, 2018

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Mar 15, 2018

Could those experiencing this please try this try build? I'm not running that build of Windows 10, so I can't test it myself, but I think this should fix it.

@jcsteh jcsteh self-assigned this Mar 15, 2018
@Qchristensen
Copy link
Member

@Qchristensen Qchristensen commented Mar 15, 2018

Just had a bit of a play with it and the voice sounds much better. It seems a bit sluggish, but I think that's my system today.

Edit: I tracked down my system sluggishness to the driver for my NetGear A6210 WiFi USB dongle - the whole thing has refused to play with Windows 10 for a number of builds now, but apparently today's update to Windows build 17120 makes the driver hog resources as well. Killed that process and everything else has picked up noticeably.

@josephsl
Copy link
Collaborator Author

@josephsl josephsl commented Mar 15, 2018

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Mar 15, 2018

Oops. This broke indexing, which means it also broke reading by character. Here's a new try build which fixes it.

As for Python 3 compat, I think there's going to be a bit of tweaking to make nvwave (and everything that uses it) Python 3 compatible, given the bytes/string stuff. Therefore, I think this is out of scope here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants