Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Win10 rs5 task switch list #8258

Merged
merged 1 commit into from May 29, 2018
Merged

Conversation

michaelDCurran
Copy link
Member

Link to issue number:

None.

Summary of the issue:

In Windows 10 RS5, The Task switcher was re-written in XAML. Therefore this means ATs lost the ability to match on a particular window class in order to suppress reporting of the switch items' ancestry, thereby causing the switcher to be way too verbose.
Microsoft however did add a UIA automation ID to the switcher list for this purpose.

Description of how this pull request fixes the issue:

Also look for the new UIA automation ID on the switcher list when choosing to use our task switcher item functionality.

Testing performed:

Alt+tabbed around Windows with multiple apps open. Confirmed that only the app names were announced, rather than the task switching window itself also. Also confirmed that pressing windows+tab still correctly announced the task switch window as it should.
If someone could test on rs4 this would be great.

Known issues with pull request:

None.

Change log entry:

Bug fixes:

  • In Windows 10 RS5, NVDA no longer reports extra redundant information when switching tasks with alt+tab.

Copy link
Collaborator

@josephsl josephsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

One thing to note is that, in RS5 (at least on build 17666), in addition to column/row, position info is also announced. Also, the code works as expected in RS4 and RS5 (so that's passed).

Thanks.

@derekriemer
Copy link
Collaborator

derekriemer commented May 14, 2018

Tested on 1803 and everything is perfect.
using
Version: next-15121,7fcd6fe7

@michaelDCurran michaelDCurran merged commit 3f54175 into master May 29, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.2 milestone May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants