Support Win10 rs5 task switch list#8258
Merged
Merged
Conversation
…d not its ancestry.
josephsl
approved these changes
May 11, 2018
Contributor
josephsl
left a comment
josephsl
left a comment
There was a problem hiding this comment.
Hi,
One thing to note is that, in RS5 (at least on build 17666), in addition to column/row, position info is also announced. Also, the code works as expected in RS4 and RS5 (so that's passed).
Thanks.
Collaborator
|
Tested on 1803 and everything is perfect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
In Windows 10 RS5, The Task switcher was re-written in XAML. Therefore this means ATs lost the ability to match on a particular window class in order to suppress reporting of the switch items' ancestry, thereby causing the switcher to be way too verbose.
Microsoft however did add a UIA automation ID to the switcher list for this purpose.
Description of how this pull request fixes the issue:
Also look for the new UIA automation ID on the switcher list when choosing to use our task switcher item functionality.
Testing performed:
Alt+tabbed around Windows with multiple apps open. Confirmed that only the app names were announced, rather than the task switching window itself also. Also confirmed that pressing windows+tab still correctly announced the task switch window as it should.
If someone could test on rs4 this would be great.
Known issues with pull request:
None.
Change log entry:
Bug fixes: