Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German Win7: LTR and RTL characters still exist in Properties Window (explorer.exe) and in the Taskbar Clock #8361

Closed
DrSooom opened this issue Jun 3, 2018 · 9 comments

Comments

@DrSooom
Copy link

commented Jun 3, 2018

NVDA-Version: NVDA 2018.2 RC2, Portable, Win7x64, German UI (de-AT)

See issue #5729 and PR #5751 and PR #8316

Date formats:

  • Taskbar clock: hh:mm, Ldddd, Ldd.Lmm.Lyyyy
  • Properties window: Ldddd, Ldd. Lmmmm Lyyyy, RLhh:mm:ss
    Hint: Open the properties window of a file/folder in the Windows Explorer.

L = U+200E (LTR), R = U+200F (RTL)

Update No. 1: Windows Explorer » Detail View » Last modified field » date format:

  • NVDA 2018.1: Ldd.Lmm.Lyyyy RLhh:mm
  • NVDA 2018.2 RC2: dd.mm.yyyy hh:mm

This works as expected. And there is no issue with an empty size field in this view in Windows Explorer.

Update No. 2: Systemsteuerung\Programme\Programme und Funktionen (Control Panel\Software\Software and features) » Detail View » Date of Installation field » date format:

  • NVDA 2018.1: Ldd.Lmm.Lyyyy
  • NVDA 2018.2 RC2: dd.mm.yyyy

This also works as expected.

@DrSooom

This comment has been minimized.

Copy link
Author

commented Jun 7, 2018

Update: This issue still exists in NVDA 2018.2 RC3.
Additional date format in the Windows Explorer properties window:

  • LHeute, L07. LJuni L2018, RLVor 25 Minuten (translated to EN: LToday, Ldd. Lmmmm Lyyyy, RLmm minutes ago)
    Hint: "ago" stands for "Vor". In German it stands before the amount of the minutes, not after.
@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2018

cc @dkager, would you be able too look into this?

@dkager

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2018

Off the top of my head I excluded some cases, such as the clock, from the PR to make it less complex. Liblouis braille tables can also filter these characters.

@DrSooom

This comment has been minimized.

Copy link
Author

commented Jun 8, 2018

Eliminating U+200E and U+200F at this early point of process has not only effects to the braille output, it also changes the pronunciation of the TTS depending of the current used synthesizer. Well, and for me: I added sign \x200e 12378 and sign \x200f 45678 in the file "de-de-comp8.ctb" years ago. So, the braille output alone isn't the point.

Well, after a quick look in PR #5751 I would say that this issue here (#8361) should be part of NVDA 2018.3 (or later) because it isn't critical at all.

Sadly the changelog entry in 2018.2 RC3 still says something complete different at all. In other words: the changelog entry should be changed from

• NVDA no longer reports (LTR and RTL marks) in Braille or per-character speech when accessing the clock in recent versions of Windows. (#5729)

to something more like "Filter LTR and RTL marks from list view items" (in the Windows Explorer) because this seems to be the current state. (I know that changing the changelog entry will have no effect in the translated changelogs to NVDA 2018.2 at this late point.)

@Adriani90

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2018

Is it still reproducible in NVDA 2018.2? I get the right reportings by speech at least. But I don't habe a braille display to test it in braille.

@DrSooom

This comment has been minimized.

Copy link
Author

commented Jun 13, 2018

Yep, the issue still exists in NVDA 2018.2. You can check this out without a braille display in moving the NVDA-Cursor by character.

@Adriani90

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2018

Hello, oh I didn't try this. Yes I can confirm.

lukaszgo1 added a commit to lukaszgo1/nvda that referenced this issue Aug 17, 2018

Remove RTL and LTR marks from various places. Fix for nvaccess#8361
Remove from clock name and value, read-only edit boxes in the properties window
Add an app module for dllhost, which is used to remove those characters from properties window on older Windows 10 builds.
@lukaszgo1

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2018

@DrSooom Can you download this build and check, that the character are gone from all the places in which you found them?

@DrSooom

This comment has been minimized.

Copy link
Author

commented Aug 17, 2018

I could test all mentioned scenarios successfully. All works now as expected with NVDA pr8643-15891,b314642b. Thanks for fixing this.

@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Mar 27, 2019

feerrenrut added a commit that referenced this issue Mar 27, 2019

Filter text direction marks from task bar clock text and from edit bo…
…xes in a properties window (PR #8643)

Fixes #8361

Filter out RTL and LTR marks from various places:
- Clock name and value
- Read-only edit boxes in the properties window

Add an app module for dllhost, which is used to remove those characters from properties window on older Windows 10 builds.
Change role of the clock icon to clock only when the word 'clock' is not present in the name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.