New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German Win7: LTR and RTL characters still exist in Properties Window (explorer.exe) and in the Taskbar Clock #8361
Comments
Update: This issue still exists in NVDA 2018.2 RC3.
|
cc @dkager, would you be able too look into this? |
Off the top of my head I excluded some cases, such as the clock, from the PR to make it less complex. Liblouis braille tables can also filter these characters. |
Eliminating U+200E and U+200F at this early point of process has not only effects to the braille output, it also changes the pronunciation of the TTS depending of the current used synthesizer. Well, and for me: I added Well, after a quick look in PR #5751 I would say that this issue here (#8361) should be part of NVDA 2018.3 (or later) because it isn't critical at all. Sadly the changelog entry in 2018.2 RC3 still says something complete different at all. In other words: the changelog entry should be changed from
to something more like "Filter LTR and RTL marks from list view items" (in the Windows Explorer) because this seems to be the current state. (I know that changing the changelog entry will have no effect in the translated changelogs to NVDA 2018.2 at this late point.) |
Is it still reproducible in NVDA 2018.2? I get the right reportings by speech at least. But I don't habe a braille display to test it in braille. |
Yep, the issue still exists in NVDA 2018.2. You can check this out without a braille display in moving the NVDA-Cursor by character. |
Hello, oh I didn't try this. Yes I can confirm. |
Remove from clock name and value, read-only edit boxes in the properties window Add an app module for dllhost, which is used to remove those characters from properties window on older Windows 10 builds.
@DrSooom Can you download this build and check, that the character are gone from all the places in which you found them? |
I could test all mentioned scenarios successfully. All works now as expected with NVDA pr8643-15891,b314642b. Thanks for fixing this. |
…xes in a properties window (PR #8643) Fixes #8361 Filter out RTL and LTR marks from various places: - Clock name and value - Read-only edit boxes in the properties window Add an app module for dllhost, which is used to remove those characters from properties window on older Windows 10 builds. Change role of the clock icon to clock only when the word 'clock' is not present in the name.
NVDA-Version: NVDA 2018.2 RC2, Portable, Win7x64, German UI (de-AT)
See issue #5729 and PR #5751 and PR #8316
Date formats:
Hint: Open the properties window of a file/folder in the Windows Explorer.
L = U+200E (LTR), R = U+200F (RTL)
Update No. 1: Windows Explorer » Detail View » Last modified field » date format:
This works as expected. And there is no issue with an empty size field in this view in Windows Explorer.
Update No. 2: Systemsteuerung\Programme\Programme und Funktionen (Control Panel\Software\Software and features) » Detail View » Date of Installation field » date format:
This also works as expected.
The text was updated successfully, but these errors were encountered: