Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version of comtypes specified in the readme.md #8522

Closed
lukaszgo1 opened this issue Jul 19, 2018 · 2 comments
Closed

Wrong version of comtypes specified in the readme.md #8522

lukaszgo1 opened this issue Jul 19, 2018 · 2 comments
Milestone

Comments

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Jul 19, 2018

Steps to reproduce:

  1. Open readme.md in the main folder of this repo.
  2. Find the line which says '* comtypes, version 1.1.4'
  3. Open NVDA log and verify, that the actual version of comtypes is 1.1.3.

Actual behavior:

The version numbers do not match.

Expected behavior:

The version numbers should be the same.

System configuration:

NVDA Installed/portable/running from source:

n/a

NVDA version:

n/a

Windows version:

n/a

Name and version of other software in use when reproducing the issue:

n/a

Other information about your system:

n/a

Other questions:

Does the issue still occur after restarting your PC?

n/a

Have you tried any other versions of NVDA?

n/a

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jul 19, 2018

This is a bit confusing indeed. The current version of comtypes we use is actually 1.1.4 minus a piece of code that introduced a bug while not adding any relevant functionality. So functionally, we are at version 1.1.4.

@lukaszgo1
Copy link
Contributor Author

@lukaszgo1 lukaszgo1 commented Jul 19, 2018

In such case it might be better to simply say comtypes and the specific commit. It has been done for example for IAccessible2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants