Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to comtypes 1.1.7 #9440

Closed
francipvb opened this issue Apr 2, 2019 · 1 comment
Closed

Upgrade to comtypes 1.1.7 #9440

francipvb opened this issue Apr 2, 2019 · 1 comment
Milestone

Comments

@francipvb
Copy link
Contributor

@francipvb francipvb commented Apr 2, 2019

Is your feature request related to a problem? Please describe.

I saw that UIA is a bit slow than other screen readers (in stable releases), but after some testing I saw a better performance with this version of comtypes, not so much, but it is notable.

Describe the solution you'd like

I don't know what should be the correct solution, because a comment from @leonardder on #8522. I was searching for the particular bug and I didn't found anything.

Describe alternatives you've considered

I whas thinking about NVDA object caching, primarily for UIAHandler because it has a bad performance, same to JABHandler. I'm planning to do some testing today.

Additional context

I saw in UIAHandler that every time that an event ocurs a new object is created. I suppose that it takes some time to instantiate it, and it impacts to NVDA's performance in heavy UIAutomation applications, such Visual Studio.

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Apr 2, 2019

There were some issues with comtypes 1.1.3, most notably causing the Handy Tech classic braille driver to stop functioning. See #7831. This was fixed in #8213, but than we had to switch back to enthought/comtypes@edbaf3b because enthought/comtypes@98f6a42 introduced another bug. See also #8213 (comment).

Having said that, I think switching to the newest comtypes should be most prefered given your findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants