New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when unicode beta support in windows 10 is turned on, add-ons fail to install #8599

Closed
zstanecic opened this Issue Aug 6, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@zstanecic
Contributor

zstanecic commented Aug 6, 2018

Steps to reproduce:

  1. o to the control panel
  2. click on regional settings
  3. go to the administrative tab.
  4. go to the language for non unicode programs settings button
  5. check the checkbox use utf-8 for the language support in all the world
  6. when prompted, restart your computer.
  7. when restarted, try to install any NVDA add-on
    It doesn't matter, which NVDA add-on you want to install

Actual behavior:

nvda produces this error in the log and fails with installation
INFO - core.main (15:24:16.638):
NVDA initialized
ERROR - gui.addonGui.AddonsDialog.installAddon (15:24:43.007):
Error installing  addon bundle from C:\BrailleExtender\BrailleExtender-dev-18.08.06-151459.nvda-addon
Traceback (most recent call last):
  File "gui\addonGui.pyc", line 160, in installAddon
  File "gui_init_.pyc", line 869, in init
LookupError: unknown encoding: cp65001

Expected behavior:

add-on wshould install normally

System configuration:

windows 10 17713 russian and windows 10 1806 17134 polish, locale polish, regional settings polish or russian locale with regional set to croatian

NVDA Installed/portable/running from source:

installed

NVDA version:

alpha-15781,d58e1cd4

Windows version:

10.0.17713.1002 or 10.0.17134 april update

Name and version of other software in use when reproducing the issue:

n/a

Other information about your system:

n/a

Other questions:

Does the issue still occur after restarting your PC?

yes, when the unicode support is enabled

Have you tried any other versions of NVDA?

no, but other versions may fail.

@Andre9642

This comment has been minimized.

Show comment
Hide comment
@Andre9642

Andre9642 Aug 6, 2018

Contributor

Hi,
A temporary fix, works for me...

Create a file with the following content:

import globalPluginHandler
import codecs
codecs.register(lambda name: codecs.lookup('utf-8') if name == 'cp65001' else None)
class GlobalPlugin(globalPluginHandler.GlobalPlugin): pass

Save the file under .py extension (e.g.: "i8599.py") and place it in "%appdata%\nvda\globalPlugins" folder (for a NVDA installed).

I don't know if the approach is good, but if it is, I could submit a fix (for NVDA core).

Contributor

Andre9642 commented Aug 6, 2018

Hi,
A temporary fix, works for me...

Create a file with the following content:

import globalPluginHandler
import codecs
codecs.register(lambda name: codecs.lookup('utf-8') if name == 'cp65001' else None)
class GlobalPlugin(globalPluginHandler.GlobalPlugin): pass

Save the file under .py extension (e.g.: "i8599.py") and place it in "%appdata%\nvda\globalPlugins" folder (for a NVDA installed).

I don't know if the approach is good, but if it is, I could submit a fix (for NVDA core).

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Aug 6, 2018

Collaborator

Hi,

I'm trying to figure out which Windows 10 release included this feature. Also, I think it'd be great if this becomes part of NVDA 2018.3. CC @nvdaes and other add-on writers.

Thanks.

Collaborator

josephsl commented Aug 6, 2018

Hi,

I'm trying to figure out which Windows 10 release included this feature. Also, I think it'd be great if this becomes part of NVDA 2018.3. CC @nvdaes and other add-on writers.

Thanks.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Aug 6, 2018

Collaborator

Hi,

Note: this is present in Windows 10 Version 1803 (April 2018 Update) and later.

Thanks.

Collaborator

josephsl commented Aug 6, 2018

Hi,

Note: this is present in Windows 10 Version 1803 (April 2018 Update) and later.

Thanks.

Andre9642 added a commit to Andre9642/nvda that referenced this issue Aug 6, 2018

Andre9642 added a commit to Andre9642/nvda that referenced this issue Aug 6, 2018

Andre9642 added a commit to Andre9642/nvda that referenced this issue Aug 7, 2018

Compatibility for the "Use Unicode UTF-8 for worldwide language suppo…
…rt" feature

=> Add cp65001 codec Temporarily
This commit should be reverted during Python3 transition
Fixes nvaccess#8599

Andre9642 added a commit to Andre9642/nvda that referenced this issue Aug 15, 2018

Compatibility for the "Use Unicode UTF-8 for worldwide language suppo…
…rt" feature

=> Add cp65001 codec Temporarily
This commit should be reverted during Python3 transition
Fixes nvaccess#8599

michaelDCurran added a commit to Andre9642/nvda that referenced this issue Aug 16, 2018

Compatibility for the "Use Unicode UTF-8 for worldwide language suppo…
…rt" feature

=> Add cp65001 codec Temporarily
This commit should be reverted during Python3 transition
Fixes nvaccess#8599

@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment