Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Lock focus-mode: #8716

Closed
LarrySilvermintz opened this issue Sep 4, 2018 · 12 comments

Comments

@LarrySilvermintz
Copy link

commented Sep 4, 2018

Overview: It is sometimes preferred to default to interacting with the Web in focus mode. For example, partially-sighted people using a magnifier with NVDA may prefer to start in, and stay in Focus Mode.
Therefore, the locked-focus setting would maintain focus-mode even when opening new browser windows, restarting the browser or possibly even when switching browsers.

First, please create a key command to lock focus mode, default could be NVDA+ctrl+space.

Second: Please create a configuration file setting to lock focus mode, The user could place this in either a global or a triggered-configuration.

@Brian1Gaff

This comment has been minimized.

Copy link

commented Sep 5, 2018

@LarrySilvermintz

This comment has been minimized.

Copy link
Author

commented Sep 5, 2018

@DrSooom

This comment has been minimized.

Copy link

commented Sep 6, 2018

Yep, a separate checkbox in the Browse Mode NVDA Settings in combination with a trigger profile could solve this issue. Furthermore it should be possible – even when NVDA is running – to scroll the website up and down via the arrow keys and via PGUP/PGDN while focus mode is on.

@LarrySilvermintz

This comment has been minimized.

Copy link
Author

commented Sep 6, 2018

@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Sep 8, 2018

At @BabbageCom, we also see the impmortance of this feature. Therefore, I will take this.

@LarrySilvermintz

This comment has been minimized.

Copy link
Author

commented Sep 8, 2018

@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2018

I've almost got it settled, however there is one thing I'd really like to implement. When someone explicitly disabled browse mode (i.e. enabled pass through), I'd like NVDA to remember that decision. So for example:

  1. Open google.com
  2. Focus the edit box with browse mode
  3. Press NVDA+space
  4. Enter a search term and press enter.

Since the user explicitly disabled browse mode here, it makes sense to remember that state. However, pass through is now remembered on a per tree interceptor basis, and since a new page load creates a new tree interceptor, the initial pass through mode gets lost.

@jcsteh or @michaelDCurran: Any idea how to address this? May be we should get rid of browseMode.reportPassThrough.last while at it, that is, it should no longer be a property on the reportPassThrough method.

@LarrySilvermintz

This comment has been minimized.

Copy link
Author

commented Sep 11, 2018

@josephsl

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

Hi,

I'm reopening this due to regression caused by the associated pull request in Microsoft Word.

Thanks.

@LarrySilvermintz

This comment has been minimized.

Copy link
Author

commented Mar 29, 2019

@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

I disagree with reopening. There's no need to reopen this as long as #8846 is not reverted. I will most likely provide a fix to this at the start of next week, which progress can be tracked in #9422. In browsers, the feature is implemented as advertised.

@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

I just confirmed that this feature works as advertised in cases where browse mode is enabled by default on page load. The regression in Word, caused by #8846, is not related to this functionality. I just filed #9423 to fix #9422. Closing this one again.

@leonardder leonardder closed this Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.