Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Incorrect reading of long lines in Notepad2 and its descendants' Scintilla control #885

Closed
nvaccessAuto opened this Issue Sep 5, 2010 · 15 comments

Comments

Projects
None yet
2 participants

Reported by oaron on 2010-09-05 13:25
In Notepad2 and its descendants, if word wrap is turned on the wrapped lines are incorrectly read by NVDA. Instead of reading the subsequent lines, NVDA repeats the whole line.
E.g. suppose we have a long line which is wrapped to 3 lines. At the first line NVDA reads all the 3 lines together (i.e. as if it wasn't wrapped at all). On the following two lines, NVDA repeats the line again, instead of reading the actual line content. As a result, we have one line wrapped to 3 lines, but NVDA reads all the 3 lines at once, and repeats it on the following 2.
Blocking #3128

Comment by jteh on 2013-04-05 03:37
(In #3128) Duplicate of #885.

Comment 2 by jteh on 2013-04-05 03:40
From memory, I don't believe Scintilla's API provides a way to fetch "soft" lines, so I'm not sure we can fix this without a change to Scintilla. However, this needs to be investigated more thoroughly.

Comment 3 by camlorn on 2013-04-07 02:45
I said this in the duplicate, but for completeness will mention it again here: this also happens in Inform 7. Fortunately, scintilla is not unbelievably popular, at least not yet.

Comment 4 by camlorn on 2013-04-20 16:39
Well, I take back my prior comment. I decided that I finally needed a proper programming editor, and...Scintilla is unbelievably popular after all.
Just as a sidenote, selecting the wrapped part of the line does work as expected at least in notepad++.

Comment 5 by jteh on 2013-06-06 01:10
I think I've managed to implement this. Please try this build: http://community.nvda-project.org/try/scintillaWordWrap/nvda_snapshot_try-scintillaWordWrap-9263,26f3840.exe

Comment 6 by jteh on 2013-06-06 01:11
@camlorn: See comment:5.

Comment 8 by clev on 2013-06-17 12:35
I've encountered the same problem in Notepad++, and you trial snapshot solves the problem yes, you may merge it.

Comment 9 by camlorn on 2013-06-18 18:15
Sorry, I've not been not checking my e-mail a lot lately. I'll try this snapshot momentarily.

Comment 10 by camlorn on 2013-06-18 18:44
I can confirm that it works as well and sorry again for not seeing this sooner.

Comment 11 by jteh on 2013-06-20 08:14
Changes:
Milestone changed from None to 2013.2

Comment 12 by mdcurran on 2013-06-21 05:06
An issue was identified where if reading text with the review cursor could loop back on itself if line wrapping was enabled and part of the wrapped line was above or below the bounds of the window. This should have been fixed and can be tested in the following try build:
http://community.nvda-project.org/try/scintillaWordWrap/nvda_snapshot_try-scintillaWordWrap-9264,8cf06c7.exe
This has been tested with Notepad++ but not with things such as SciTE. If testing with these, try to load a big document that does not entirely fit on the screen. Keep the caret (insertion point) at the top of the document, but move to the bottom of the document with NVDA's review cursor. Then see if you can read the lines with the review cursor going up the document.

Comment 13 by jteh on 2013-06-26 02:54
Changes:
Milestone changed from 2013.2 to next

Comment 14 by mdcurran on 2013-06-27 02:47
Changes:
Added labels: incubating

Comment 15 by James Teh <jamie@... on 2013-07-11 12:35
In [435e8f0]:

In Scintilla controls, lines are now reported correctly when word wrap is enabled.

There is no direct way to retrieve information about wrapped lines, but this can be achieved using screen coordinates.
Fixes #885.

Changes:
Removed labels: incubating
State: closed

Comment 16 by jteh on 2013-07-11 12:35
Changes:
Milestone changed from next to 2013.2

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 2013.2 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment