Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with other Visual Studio 2017 editions (eg. Professional) #8939

Closed
JulienCochuyt opened this Issue Nov 13, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@JulienCochuyt
Copy link
Contributor

commented Nov 13, 2018

Steps to reproduce:

Attempt to build NVDA using Visual Studio 2017 Professional

Actual behavior:

The build fails because the file Microsoft.VC141.CRT cannot be found.
Indeed, in nvdaHelper/localWin10/sconscript, the glob Microsoft Visual Studio\2017\Community\VC\Redist\MSVC\14.1*\x86\Microsoft.VC141.CRT does not resolve to any file.

Expected behavior:

Replace the above-mentioned glob with Microsoft Visual Studio\2017\*\VC\Redist\MSVC\14.1*\x86\Microsoft.VC141.CRT, that is just replace Community with * to allow resolving to the required file when using an edition of Visual Studio different from Community.

System configuration:

NVDA Installed/portable/running from source:

Building NVDA from source

NVDA version:

Since #7568, that is version 2017.4rc1 and above, including latest master.

Windows version:

10.0.17134 Numéro 17134

Name and version of other software in use when reproducing the issue:

Visual Studio 2017 Professional version 15.6.1

Other information about your system:

Other questions:

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Nov 13, 2018

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Nov 28, 2018

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Nov 28, 2018

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Dec 4, 2018

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Dec 4, 2018

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Dec 4, 2018

@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Dec 5, 2018

michaelDCurran added a commit that referenced this issue Dec 5, 2018

Allow building with other Visual Studio 2017 editions (eg. Profession…
…al) (#8940)

* Allow building with other Visual Studio 2017 editions (eg. Professional) (#8939)

* Use SCons to determine MSVC installation path (#8939)

* Fetch VC version from `env` (#8939)

* Update what's new.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.