Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more "hidden options" to the Advanced NVDA Settings #9206

Open
DrSooom opened this issue Jan 27, 2019 · 10 comments
Open

Add more "hidden options" to the Advanced NVDA Settings #9206

DrSooom opened this issue Jan 27, 2019 · 10 comments
Labels
blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. component/NVDA-GUI feature needs-triage p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

Comments

@DrSooom
Copy link

DrSooom commented Jan 27, 2019

Actual behaviour:

The following "hidden options" can only be changed directly in the "nvda.ini":

  • beepSpeechModePitch
  • speechPercentageInterval
  • beepPercentageInterval
  • beepMinHZ
  • audioCoordinates_blurFactor
  • audioCoordinates_minVolume
  • audioCoordinates_maxVolume
  • audioCoordinates_minPitch
  • audioCoordinates_maxPitch
  • [UIA] minWindowsVersion
  • [UIA] enabled

Expected behaviour:

  1. Include them all to the Advanced NVDA Settings, so that they can be changed via the GUI.
  2. Add a validation check for all of them too.
  • beepSpeechModePitch: text field (min = 55, max = 8372, default = 880)
    Note: I guess the default value here is/was 8000 Hz, which hurts extremely in my ears. So reducing it directly to 880 Hz would be nice.
  • speechPercentageInterval: text field (min = 1, max = 25, default = 10)
  • beepPercentageInterval: text field (min = 1, max = 25, default = 1)
  • beepMinHZ: text field (min = 55, max = 4186, default = 110)
  • audioCoordinates_blurFactor: text field (min = 1, max = 15, default = 3)
  • audioCoordinates_minVolume: text field (min = 0.000, max = 0.999, default = 0.1)
  • audioCoordinates_maxVolume: text field (min = 0.001, max = 1.0, default = 1.0)
  • audioCoordinates_minPitch: text field (min = 55, max = 4186, default = 220)
  • audioCoordinates_maxPitch: text field (min = 110, max = 8372, default = 880)
  • [UIA] minWindowsVersion: text field (min = 6.1, max = 10.0, default = 6.1)
  • [UIA] enabled: checkbox (true and false, default = true)
  1. Describe them all in detail in the NVDA's User Guide (like in chapter 15.1 "Command Line Options").

Note regarding the Hz values:

55 Hz = A1, 110 Hz = A2, 220 Hz = A3, 880 Hz = A5, 4186 Hz = C8 and 8372 Hz = C9

System configuration:

NVDA version:

  • The above mentioned "hidden options" are part from the "nvda.ini" of NVDA 2012.2.1 (and a little bit higher), as far as I remember me correctly. They were never deleted during updating NVDA from 2012.2.1/2013.2 to 2018.1. (I used NVDA 2012.2.1 to 2013.2 as a portable app.)
  • In newer NVDA versions, maybe since introducing the second schema version for the "nvda.ini", only different values in compare with the default once are saved in the "nvda.ini".
  • The "Advanced Settings" is a new category in the NVDA Settings in NVDA alpha-16619 (alpha build for the upcoming 2019.1), which I haven't tested now. I got this information from PR Make UIA in MS Word optional again, through an Advanced Settings category #9200.

Windows version:

Windows 7 to Windows 10 1809 (and 19H1 and higher)

@josephsl
Copy link
Collaborator

josephsl commented Jan 27, 2019 via email

@Brian1Gaff
Copy link

Brian1Gaff commented Jan 27, 2019 via email

@LeonarddeR
Copy link
Collaborator

#9200 intends to implement the most important advanced settings. I think this issue is good for a new developer whenever #9200 is merged into master. I'm pretty sure that it is very low on the priority list of both NV Access and other volunteer developers though.

@feerrenrut
Copy link
Contributor

I think many of these are really customization related and don't belong in the advanced settings panel. I would prefer customization for these things to be handled in a more user friendly way.

@Adriani90
Copy link
Collaborator

At least for the speech and Audio Settings it would be good to have These two:
• speechPercentageInterval
• beepPercentageInterval
Maybe as part of speech Settings. We could rename the cathegory like "speech and Audio Settings".

Concerning the hz and pitch of tones, I would rather prefer replacing the tones with softer tones which are not so shrill.

@DrSooom
Copy link
Author

DrSooom commented Feb 4, 2019

@feerrenrut: I fully agree with you. But making them accessible via the GUI should be done first. Well, as everybody here will also acknowledge to, is that the priority of this issue here is just a p4. Personally I don't want to have hidden options, which aren't documented.

@Adriani90: See issue #8711. Your suggestion would split the progress bar audio feedback and their intervals into two different panels, which isn't user-friendly. Furthermore all settings in the speech panels are related to the current TTS, as far as I know and understood it correctly. So the two interval settings shouldn't be related to a TTS, because they are generally used.

@DrSooom
Copy link
Author

DrSooom commented Nov 3, 2019

Related issue: #6788

@zahra21

This comment was marked as off-topic.

@feerrenrut feerrenrut added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority and removed z goodForNewDev (archived) labels Mar 26, 2020
@feerrenrut
Copy link
Contributor

Most of these config items aren't very user friendly, which is an important consideration. Rather than exposing these via the settings menu, I'd prefer to incorporate them into a new type of "audio theme" addon along with customisation of other sounds in NVDA.

@seanbudd seanbudd added blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. needs-triage labels May 28, 2024
@seanbudd
Copy link
Member

#10804 includes some important discussion on how some of these could be implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. component/NVDA-GUI feature needs-triage p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Development

No branches or pull requests

8 participants