Perform lower case comparison of add-on names when updating, and make sure not to remove the previous add-on when the current add-on fails installation #9334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Steps to reproduce lowercase comparison issue
TEST
test
Expected
TEST
andtest
are considered the same add-onActual
test
is not the same asTEST
, sotest
installs without removingTEST
Description of how this pull request fixes the issue:
When trying to find an existing add-on with the same name, use lower case string matching.
Steps to reproduce failing add-on update issue
Expected
The old version of test remains on the system
Actual
Neither the old nor the new version of test will be available after restarting NVDA, since the old version was marked for removal.
Description of how this pull request fixes the issue:
Mark the previous add-on for removal when the new version has been installed successfully.
Testing performed:
Tested the steps to reproduce above
Known issues with pull request:
None
Change log entry: