Perform lower case comparison of add-on names when updating, and make sure not to remove the previous add-on when the current add-on fails installation

[LeonarddeR]

Link to issue number:

None

Steps to reproduce lowercase comparison issue

1. Install an add-on called TEST
2. Install an add-on called test

Expected

TEST and test are considered the same add-on

Actual

test is not the same as TEST, so test installs without removing TEST

Description of how this pull request fixes the issue:

When trying to find an existing add-on with the same name, use lower case string matching.

Steps to reproduce failing add-on update issue

1. Install an add-on called test
2. Update the add-on with a new version which onInstall function raises an exception

Expected

The old version of test remains on the system

Actual

Neither the old nor the new version of test will be available after restarting NVDA, since the old version was marked for removal.

Description of how this pull request fixes the issue:

Mark the previous add-on for removal when the new version has been installed successfully.

Testing performed:

Tested the steps to reproduce above

Known issues with pull request:

None

Change log entry:

• Bug fixes
  • Add-ons with names that only differ in capitalization are no longer treated as separate add-ons.

[feerrenrut]

I wonder what would be required to use a separate ID for the addons. There may be some UX concerns anyway to have multiple addons installed with the same name.

[LeonarddeR]

Yes, I think it is. It looks like everyone assumes that the name of the add-on and the folder in which it resides are equal. Regardless, NVDA only compares the name from the manifest when installing, and this logic really should be case insensitive as this pr ensures.

[feerrenrut]

I just tested this, and to clarify; the convention is that the name of the folder matches the name of the addon, during installation of the addon nvda creates the folder to match the name of the addon. If the folder name is changed, the addon is still loaded.