Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddonsDialog: some add-ons are marked as Enabled when NVDA is launched with --disable-addons flag #9473

Closed
DataTriny opened this issue Apr 9, 2019 · 6 comments

Comments

@DataTriny
Copy link
Contributor

commented Apr 9, 2019

Steps to reproduce:

  1. Launch NVDA.
  2. Make sure you have at least one add-on installed.
  3. Close NVDA.
  4. Launch NVDA from the command line with the --disable-addons flag.
  5. Open the add-on manager dialog.

Actual behavior:

Add-ons that are enabled on your profile will appear as enabled on the dialog.

Expected behavior:

Since NVDA has been told to start with all add-ons disabled, and since they are effectively not running, they shouldn't appear as enabled.

I found this when looking at #5785.

Since a label indicates that you must restart NVDA to re-enable your add-ons, and because the --disable-addons will likely be used by people who know what they're doing, I am wondering if we shouldn't disable this dialog and its menu entry all together.

System configuration

NVDA installed/portable/running from source:

NVDA Installed.

NVDA version:

NVDA 2019.1.

Windows version:

Windows 10 Education version 1809.

Other questions

Does the issue still occur after restarting your PC?

Yes.

Have you tried any other versions of NVDA?

No.

@fisher729

This comment has been minimized.

Copy link

commented Apr 9, 2019

Confirmed.

My recommended action/fix would be to:

  1. Leave the add-on dialog enabled.
  2. Each add-on should be marked as disabled.
  3. No option to enable or disable them should be present.
@DataTriny

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

I agree. Will try to implement this soon!

@feerrenrut

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

I am wondering if we shouldn't disable this dialog and its menu entry all together.

The dialog is still useful, allowing users to get information about their addons and uninstall them. This is particularly useful if an addon is causing a usability problem.

@fisher729

This comment has been minimized.

Copy link

commented Apr 9, 2019

@josephsl

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

Hi,

I'm wondering if the root problem is #6275? I'll do some tests to see if it is indeed a mistake from that one with 2018.4.

Thanks.

@josephsl

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

Hi,

Yep, testing shows this is a regression.

Thanks.

@josephsl josephsl added the regression label Apr 11, 2019

@nvaccessAuto nvaccessAuto added this to the 2019.2 milestone Apr 12, 2019

feerrenrut added a commit that referenced this issue Apr 12, 2019

Update changes file for PR #9474
Clarification to the text in the add-on manager when NVDA is launched with the --disable-addons flag. (Issue #9473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.