Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA reads whole text in vs2008 code editor on each typed character #975

Closed
nvaccessAuto opened this issue Oct 8, 2010 · 5 comments
Closed
Labels
Milestone

Comments

@nvaccessAuto
Copy link

Reported by aleksey_s on 2010-10-08 21:43
When I type in vs 2008 code editor, NVDA tries to read the whole text after each key press. It is rather annoying.

@nvaccessAuto
Copy link
Author

Comment 1 by aleksey_s on 2011-02-05 16:49
It is caused by event_valueChange on the editor object. I can provide a patch to ignore this event for the devenv app module, but I wonder is it a right way to fix it? Why we don't ignore value change events on editable controls in general?

@nvaccessAuto
Copy link
Author

Comment 2 by jteh (in reply to comment 1) on 2011-02-06 00:36
Replying to aleksey_s:

Why we don't ignore value change events on editable controls in general?

Because in theory (and perhaps even in practice for some controls), not all editable text controls use the value to represent text. They aren't necessarily one and the same. The abstraction should only know about text, not value, as value is an implementation detail.

@nvaccessAuto
Copy link
Author

Comment 3 by aleksey_s on 2011-02-06 08:42
So if you have nothing against the fix, I'll commit it into main. Without it, usability of NVDA in visual studio is doubtful.
Changes:
Milestone changed from None to 2011.1

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2011-02-06 20:26
Alright. We're heading into a translatable string freeze soon, though, so once that happens, user visible changes since the last release need to be avoided where possible to avoid unnecessary changes to the What's New. In other words, this is probably the last change like this that will make it into the release and it needs to be done in the next day or two. This does need a What's New entry in bug fixes.

@nvaccessAuto
Copy link
Author

Comment 5 by aleksey_s on 2011-02-07 06:07
Fixed in 5f10c7b.
Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2011.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant