New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix name of visual highlight in 2020.4 changes #12021
Conversation
@feerrenrut I think this minor PR should be included before translation freeze if possible. |
Unfortunately the translation freeze has already started and due to finish on the 4th of Feb. |
I'm going to re-target this PR to master. |
The extra commits will disappear when I merge beta into master (independently of this PR). |
bdba1cf
to
97687f8
Compare
I've cleaned up this PR for a merge to master and made a few minor language fixes for 2021.1. Cc @feerrenrut, @michaelDCurran. |
- <code>LiveText._getTextLines</code> has been removed. (#11639) | ||
- Instead, override <code>_getText</code> which returns a string of all text in the object. | ||
- <code>LiveText</code> objects can now calculate diffs by character. (#11639) | ||
- To alter the diff behaviour for some object, override the <code>diffAlgo</code> property (see the docstring for details). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about using <code>
directly. txt2tags does support several options eg two times back tick for monospace, two times double quote for raw and two times single quote for tagged. I'm not really sure what raw and tagged mean:
Here is a quick overview of these formatting options: https://txt2tags.org/manpage.html
The user guide has more options and info in "Part V - Mastering Marks"
@codeofdusk Will you be continuing with this work? |
@codeofdusk Ping. Do you intend to work further on this? |
Superseded. |
Change "vision highlight" to "visual highlight" in changelog to make more consistent with GUI.
Cc @feerrenrut @michaelDCurran.