Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Diff Match Patch by default when available #12485

merged 4 commits into from Jun 2, 2021


Copy link

@codeofdusk codeofdusk commented May 31, 2021

Link to issue number:


Summary of the issue:

Diff Match Patch (DMP) was included but disabled by default in 2021.1. It fixes #3200 and allows for drastically fewer cross-process calls in UIA console, improving performance in busy applications.

Description of how this pull request fixes the issue:

This PR enables DMP by default to allow for wider user testing in master snapshots. If user feedback is positive, use by default in 2021.2.

Testing strategy:

Verified that DMP is used by default when feature flag is set to auto and Difflib when feature flag is set to force Difflib.

Known issues with pull request:


Change log entries:

== Bug Fixes ==

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@codeofdusk codeofdusk requested review from a team as code owners May 31, 2021 03:30
Copy link

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have a suggestion for a docs change but the code looks good to me. Also pending approval from @Qchristensen

user_docs/en/userGuide.t2t Outdated Show resolved Hide resolved
Co-authored-by: Sean Budd <>
Copy link

userGuide change looks good - is there a change log entry? It's hiding from me.

Copy link

seanbudd commented Jun 2, 2021

@Qchristensen - we generally update the changelog manually just before merging. I've added this now, just need your approval to merge.

Copy link

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserGuide & Changes text looks good, thanks!

@seanbudd seanbudd merged commit c9bb993 into nvaccess:master Jun 2, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jun 2, 2021
@codeofdusk codeofdusk deleted the dmp-by-default branch June 3, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

better support for editing characters in the middle of lines in command prompt/terminal
4 participants