Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the config using the integer value of a SymbolLevel enum member #12636

merged 3 commits into from Jul 12, 2021


Copy link

@seanbudd seanbudd commented Jul 12, 2021

Link to issue number:

Fixes #12630, caused by #11856

Summary of the issue:

SYMLVL_* constants were moved to an IntEnum. When updating the config for symbolLevel, the type being set is Enum, as opposed to int. Additionally, the enum does not conform to our naming standards

Description of how this pull request fixes the issue:

Sets the config using the value of the enum member. Renames SYMLVL to SymbolLevel.

Testing strategy:

Manual testing of the config using the steps in #12630. Set the symbolLevel via NVDA settings and quick keys and ensure the config can be used on restart.

System testing for setting the NVDA config could be added in the future.

Known issues with pull request:


Change log entries:

None needed, just fixed the earlier developer changes message for #11856

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@seanbudd seanbudd requested a review from a team as a code owner July 12, 2021 01:49
@seanbudd seanbudd changed the title Set integer value of SymLvl enum to config Set the config using the integer value of a SymbolLevel enum member Jul 12, 2021
@seanbudd seanbudd merged commit 7b331b0 into master Jul 12, 2021
@seanbudd seanbudd deleted the fix-12630 branch July 12, 2021 02:59
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone Jul 12, 2021
aaclause added a commit to aaclause/BrailleExtender that referenced this pull request Oct 26, 2021
See nvaccess/nvda#12510, nvaccess/nvda#11856 and nvaccess/nvda#12636

According to the NVDA change log:

> - `characterProcessing.SYMLVL_*` constants should be replaced using their equivalent `SymbolLevel.*` before 2022.1.
> - controlTypes has been split up into various submodules, symbols marked for deprecation must be replaced before 2022.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

After changing symbol level and saving configuration NVDA corrupts its own config.
3 participants