Set the config using the integer value of a SymbolLevel enum member #12636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
changed the title
feerrenrut
approved these changes
Jul 12, 2021
aaclause
added a commit
to aaclause/BrailleExtender
that referenced
this pull request
Oct 26, 2021
See nvaccess/nvda#12510, nvaccess/nvda#11856 and nvaccess/nvda#12636 According to the NVDA change log: > - `characterProcessing.SYMLVL_*` constants should be replaced using their equivalent `SymbolLevel.*` before 2022.1. > - controlTypes has been split up into various submodules, symbols marked for deprecation must be replaced before 2022.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12630, caused by #11856
Summary of the issue:
SYMLVL_* constants were moved to an IntEnum. When updating the config for symbolLevel, the type being set is Enum, as opposed to int. Additionally, the enum does not conform to our naming standards https://github.com/nvaccess/nvda/blob/master/devDocs/codingStandards.md#identifier-names.
Description of how this pull request fixes the issue:
Sets the config using the value of the enum member. Renames
SYMLVLtoSymbolLevel.Testing strategy:
Manual testing of the config using the steps in #12630. Set the symbolLevel via NVDA settings and quick keys and ensure the config can be used on restart.
System testing for setting the NVDA config could be added in the future.
Known issues with pull request:
None
Change log entries:
None needed, just fixed the earlier developer changes message for #11856
Code Review Checklist: