Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log for beta: little fixes #12677

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Jul 23, 2021

Link to issue number:

None

Summary of the issue:

Some issues have been found in the change log for NVDA 2021.2:

  1. The following item of the change log landed in the wrong section (bugfix instead of changes)in spite of what was specified in the PR:
- Updated liblouis braille translator to [3.18.0 https://github.com/liblouis/liblouis/releases/tag/v3.18.0]. (#12526)
  - New braille tables: Bulgarian grade 1, Burmese grade 1, Burmese grade 2, Kazakh grade 1, Khmer grade 1, Northern Kurdish grade 0, Sepedi grade 1, Sepedi grade 2, Sesotho grade 1, Sesotho grade 2, Setswana grade 1, Setswana grade 2, Tatar grade 1, Vietnamese grade 0, Vietnamese grade 2, Southern Vietnamese grade 1, Xhosa grade 1, Xhosa grade 2, Yakut grade 1, Zulu grade 1, Zulu grade 2
  -
  1. A wrong reference to NVDA should support DAP program #1256 has been written instead of Refactor COM Registration Fixing Tool part 1: make the tool effective on 64-bit Windows and fix more problems #12560 for the following entry:
    The COM Registration Fixing Tool now resolves more issues, especially on 64 bit Windows. (

Description of how this pull request fixes the issue:

  1. Moved this item in the change log.
  2. Fixed the PR's reference.

Testing strategy:

Change log to be checked when the build is done.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@CyrilleB79 CyrilleB79 requested a review from a team as a code owner July 23, 2021 09:31
@CyrilleB79 CyrilleB79 requested review from seanbudd and removed request for a team July 23, 2021 09:31
@CyrilleB79
Copy link
Collaborator Author

Confirmed with appVeyor artifact that the generated change log is OK.

Cc @seanbudd, @feerrenrut

@lukaszgo1
Copy link
Contributor

Since you're fixing mistakes in change log for 2021.2 could you also fix a wrong Pr reference in the entry
"• The COM Registration Fixing Tool now resolves more issues, especially on 64 bit Windows. (#1256)"
the issue number should be #12560

@CyrilleB79 CyrilleB79 changed the title Change log: Move an item that landed in the wrong section. Change log for beta: little fixes Jul 23, 2021
@CyrilleB79
Copy link
Collaborator Author

Thanks @lukaszgo1. This is fixed and has been checked in appVeyor artifact.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up on this, LGTM

@seanbudd seanbudd merged commit c3050a0 into nvaccess:beta Jul 26, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Jul 26, 2021
@CyrilleB79 CyrilleB79 deleted the changeLogSection branch July 27, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants