Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update liblouis to 3.20.0 #13141

Merged
merged 4 commits into from Dec 8, 2021
Merged

Update liblouis to 3.20.0 #13141

merged 4 commits into from Dec 8, 2021

Conversation

aaclause
Copy link
Contributor

@aaclause aaclause commented Dec 7, 2021 •
edited by seanbudd

Link to issue number:

Closes #2736

Summary of the issue:

Liblouis 3.20.0 has been released.

Description of how this pull request fixes the issue:

Updates liblouis to 3.20.0 which offers among other things new table for braille kanji and major updates to the Polish, Chinese, Russian literary and the UEB tables. Changelog.

Testing strategy:

Ran from sources and try build then loaded the new Japanese braille table. LGTM.

Known issues with pull request:

Change log entries:

Section: Changes

- Updated liblouis braille translator to [3.20.0 https://github.com/liblouis/liblouis/releases/tag/v3.20.0]. (#13141)
  - New braille table: Japanese (Kantenji) literary braille

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@AppVeyorBot
Copy link

See test results for failed build of commit 43d3595520

@lukaszgo1
Copy link
Contributor

@aaclause Would you mint to rename Polish Grade 1 to Polish Literary to remain consistent with the rename I did in liblouis/liblouis#1111?

@LeonarddeR
Copy link
Collaborator

Known issues with pull request:

Yes. Please rename to Dutch (6 dot) as well, in accordance with the 8 dot naming.

LeonarddeR
LeonarddeR reviewed Dec 7, 2021
View reviewed changes
source/brailleTables.py Outdated Show resolved Hide resolved
@aaclause @LeonarddeR
Update source/brailleTables.py
c1b3a51 
Co-authored-by: Leonard de Ruijter <leonardder@users.noreply.github.com>
@aaclause aaclause marked this pull request as ready for review December 7, 2021 18:22
@aaclause aaclause requested a review from a team as a code owner December 7, 2021 18:22
@seanbudd seanbudd merged commit d344442 into nvaccess:master Dec 8, 2021
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Dec 8, 2021
@nishimotz nishimotz mentioned this pull request Dec 12, 2021
Closed
@seanbudd seanbudd mentioned this pull request May 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonarddeR LeonarddeR LeonarddeR approved these changes

@seanbudd seanbudd seanbudd approved these changes

@michaelDCurran michaelDCurran Awaiting requested review from michaelDCurran michaelDCurran is a code owner automatically assigned from nvaccess/developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.

support for Japanese braille
6 participants
@aaclause @AppVeyorBot @lukaszgo1 @LeonarddeR @seanbudd @nvaccessAuto