Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EditTextInfo for RichEdit50 controls #13950

Closed
wants to merge 1 commit into from
Closed

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Jul 26, 2022

Opening draft PR to start build

Link to issue number:

Fixes #13420, #13927

Summary of the issue:

TODO

Description of user facing changes

Review cursor and system cursor tracking fixed for RichEdit50 controls (e.g. NVDA log viewer, Bookworm).

Description of development approach

Use EditTextInfo for RichEdit50 controls.

Testing strategy:

TODO

Known issues with pull request:

Bookworm sayAll stops after each page. This is different behaviour to 2022.2, where sayAll continues on the new page.
This is better than the current behaviour on master, which causes sayAll to be caught in an infinite loop scrolling at the bottom of the last page.

Change log entries:

Bug fixes

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@seanbudd seanbudd marked this pull request as ready for review July 26, 2022 04:23
@seanbudd seanbudd requested a review from a team as a code owner July 26, 2022 04:23
@seanbudd seanbudd requested review from feerrenrut and removed request for a team July 26, 2022 04:23
@seanbudd seanbudd changed the base branch from masterToBeta to master July 26, 2022 04:23
@seanbudd seanbudd marked this pull request as draft July 26, 2022 04:23
@seanbudd seanbudd added the release/blocking this issue blocks the milestone release label Jul 26, 2022
@seanbudd seanbudd linked an issue Jul 26, 2022 that may be closed by this pull request
@seanbudd seanbudd changed the base branch from master to beta July 26, 2022 06:08
@seanbudd seanbudd added this to the 2022.3 milestone Jul 26, 2022
@LeonarddeR
Copy link
Collaborator

Please note that Wordpad also has a RichEdit50 and there, it works just fine. That made me think that it is just the ITextDocument implementation in WX that's broken. On the contrary, the UIA implementation works properly, I wonder what that uses under the hood.
Anyhow, I think this pr should be limited to WX windows only, i.e. there should be a wx window class on one of the parent windows.

@lukaszgo1
Copy link
Contributor

I'm not sure this PR is a right approach:

In short it seems more reasonable to fix the regression from #13670 for 2022.3, and then try to identify what goes wrong when setting caret in WX RichEdit - perhaps it would be possible to use method for setting caret from non richedit controls and keep the rest of the support from richedit.

@seanbudd seanbudd removed the release/blocking this issue blocks the milestone release label Jul 27, 2022
@seanbudd seanbudd changed the base branch from beta to master July 27, 2022 06:05
@seanbudd seanbudd closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants