Ensure indeterminate progress dialogs centred on screen before visible

[seanbudd]

Link to issue number:

None

Summary of the issue:

The NVDA update checker and other indeterminate progress dialogs become visible before they are centred on screen.

Description of user facing changes

Indeterminate progress dialogs used in NVDAs GUI are centred before they become visible, and do not jump across the screen.

Description of development approach

Change the order of raise and centre on screen

Testing strategy:

1. Download and install the build from this PR
2. Note that the "Updating NVDA dialog" appears centred on screen and does not jump across.

Known issues with pull request:

None

Change log entries:

Not required

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests. See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/x9o6p40497hwu7pt/artifacts/output/nvda_snapshot_pr14024-26199,6bfe0386.exe

See test results for failed build of commit 6bfe038668

[seanbudd]

@k-kolev1985 can you confirm this PR build fixes the problem in #12192?

[k-kolev1985]

I updated from an alpha version of NVDA to this PR via the provided installer. The NVDA update installation progress dialog was still not centered on the screen - it was in the top left part of the screen. Did I do something wrong?

[seanbudd]

No, those steps are correct.

I thought this would fix the problem as the "Updating NVDA" dialog uses Indeterminate progress dialogs.
It seems that these dialogs cannot be centred before becoming visible as init makes them visible.

I wonder if #13254 fixes this for you