Display in braille the character number upon request #14837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14826
Summary of the issue:
When pressing 3 times numpad2, the character number is reported by speech (both in decimal form and hexadecimal form). However, for braille users it would be useful to have this information.
Description of user facing changes
When pressing three times numpad2 to call the script "Report current character in review", the reported information (character number in decimal and hexadecimal) is also reported in braille, not only by speech.
First press and second press of this script remain unchanged since:
Description of development approach
Added a braille update as done in
ui.message
. We do not use directlyui.message
since the hex value has to be spelt.Testing strategy:
Manual testing:
Pressed once, twice and 3 times numpad2; and checked that:
Known issues with pull request:
None
Change log entries:
New features
When pressing three times numpad2 to report the numerical value of the character at the position of the review cursor, the information is now also provided in braille. (#14826)
Note: better wording welcome if needed; cc @XLTechie
Code Review Checklist: