Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup 'Temporary Copy restrictions' in the user guide #15222

Merged
merged 2 commits into from Jul 31, 2023
Merged

Fixup 'Temporary Copy restrictions' in the user guide #15222

merged 2 commits into from Jul 31, 2023

Conversation

seanbudd
Copy link
Member

Link to issue number:

None

Summary of the issue:

#13985 introduced new restrictions for temporary copies of NVDA, preventing the add-on store from opening and preventing writing to disk.
These should be explained in the user guide

Description of user facing changes

N/A

Description of development approach

Simplified some of the structure in the user guide, including explaining what a temporary copy is.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner July 30, 2023 23:52
@seanbudd seanbudd requested review from Qchristensen and removed request for a team July 30, 2023 23:52
@seanbudd seanbudd added this to the 2023.2 milestone Jul 30, 2023
Qchristensen
Qchristensen previously approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Sean!

@seanbudd seanbudd merged commit 084dd34 into beta Jul 31, 2023
1 check was pending
@seanbudd seanbudd deleted the addTempNotes branch July 31, 2023 00:00
CyrilleB79
CyrilleB79 reviewed Jul 31, 2023
View reviewed changes
user_docs/en/userGuide.t2t

Apart from the inability to automatically start during and/or after log-on, the portable and temporary copies of NVDA also have the following restrictions:
The [NVDA installer #StepsForRunningTheDownloadLauncher] can be used as a temporary copy of NVDA.
Temporary copies prevent saving NVDA configuration such as settings or input gestures.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanbudd, @Qchristensen, that is not true (at least for NVDA 2023.2beta1).
Indeed, modifying the gestures is allowed while running temp version of NVDA.

I think that the idea was to prevent writing on disk in temp versions only if it might cause issue with the installed version. E.g.: writing the config the config (settings) on the disk is not allowed because the config scheme (version) may be different and incompatible between installer and installed version. On the contrary writing gestures from a newer version does not cause any problem to older version: non-existing scripts are just silently ignored by the older version. If NVAccess changes the behaviour, it should be clarified and the reasons of it should be explained to developers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed up in #15248

Note that the intention was actually to prevent any config from being saved to disk, as NVDA should be treated as a fully temporary copy in this case. This will be addressed in 2023.3 with more clear restrictions around secure screens, and temporary copies

@Brian1Gaff
Copy link

Brian1Gaff commented Jul 31, 2023 via email

@CyrilleB79
Copy link
Collaborator

@Brian1Gaff, you are making a confusion between portable and temporary copy.

As indicated more explicitly in the documentation just modified in this PR:

The NVDA installer can be used as a temporary copy of NVDA.

Thus the temporary copy of NVDA is not a portable one, but just the instance of NVDA executing when you launch the installer.

seanbudd added a commit that referenced this pull request Aug 2, 2023
@seanbudd
Fixup #15222: User Guide temporary copies
531d4a2
seanbudd added a commit that referenced this pull request Aug 2, 2023
@seanbudd
Fixup #15222: User Guide temporary copies
525ad3f
@seanbudd seanbudd mentioned this pull request Aug 2, 2023
Merged
seanbudd added a commit that referenced this pull request Aug 3, 2023
@seanbudd
Fixup #15222: User Guide temporary copies (#15248)
fe59554 
Fixup #15222 due to #15222 (comment)

Summary of the issue:
NVDA does not currently prevent saving input gestures when running a temporary copy

Description of user facing changes
Fix user guide to be more accurate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrilleB79 CyrilleB79 CyrilleB79 left review comments

@Qchristensen Qchristensen Qchristensen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seanbudd @Brian1Gaff @CyrilleB79 @Qchristensen