Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default gesture for the screen curtain #15590

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Default gesture for the screen curtain #15590

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
498535f
Default gesture for the screen curtain
CyrilleB79 Oct 6, 2023
ae72476
Apply suggestions from code review
CyrilleB79 Oct 9, 2023
b6fef4b
fix grammar
seanbudd Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/globalCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4174,7 +4174,8 @@ def script_toggleReportCLDR(self, gesture):
"Pressed once, screen curtain is enabled until you restart NVDA. "
"Pressed twice, screen curtain is enabled until you disable it"
),
category=SCRCAT_VISION
category=SCRCAT_VISION,
gesture="kb:NVDA+control+escape",
)
def script_toggleScreenCurtain(self, gesture):
scriptCount = scriptHandler.getLastScriptRepeatCount()
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ What's New in NVDA
- The following commands now support two and three presses to spell the reported information and spell with character descriptions: report selection, report clipboard text and report focused object. (#15449)
- The option "Report role when mouse enters object" in NVDA's mouse settings category has been renamed to "Report object when mouse enters it".
This option now announces additional relevant information about an object when the mouse enters it, such as states (checked/pressed) or cell coordinates in a table. (#15420)
- The command to toggle the screen curtain has now a default gesture: ``NVDA+control+escape``. (#10560)
seanbudd marked this conversation as resolved.
Show resolved Hide resolved
-

== Bug Fixes ==
Expand Down
7 changes: 5 additions & 2 deletions user_docs/en/userGuide.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,6 +1090,11 @@ For this situation, NVDA contains a feature called "Screen Curtain" which can be

You can enable the Screen Curtain in the [vision category #VisionSettings] of the [NVDA Settings #NVDASettings] dialog.

%kc:beginInclude
|| Name | Key | Description |
| Toggles the state of the screen curtain | ``NVDA+control+escape`` | Enable to make the screen black or disable to show the contents of the screen. Pressed once, screen curtain is enabled until you restart NVDA. Pressed twice, screen curtain is enabled until you disable it. |
%kc:endInclude

When the Screen Curtain is active some tasks directly based on what appears on the screen such as performing [OCR #Win10Ocr] or taking a screenshot cannot be achieved.

Due to a change in the Windows Magnification API, Screen Curtain had to be updated to support the newest versions of Windows.
Expand Down Expand Up @@ -1859,8 +1864,6 @@ If you are sure, you can choose the Yes button to enable the screen curtain.
If you no longer want to see this warning message every time, you can change this behaviour in the dialog that displays the message.
You can always restore the warning by checking the "Always show a warning when loading Screen Curtain" check box next to the "Make screen black" check box.

To toggle the Screen Curtain from anywhere, please assign a custom gesture using the [Input Gestures dialog #InputGestures].

By default, sounds are played when the Screen Curtain is toggled.
When you want to change this behaviour, you can uncheck the "Play sound when toggling Screen Curtain" check box.

Expand Down