Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate text reporting in Visual Studio text controls #15838

Merged
merged 4 commits into from Nov 28, 2023

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Nov 27, 2023

Link to issue number:

follow up of #14888

Summary of the issue:

During development of #14888, it was observed that XAML edit fields tend to fire text change events before the caret position is changed, resulting in wrong text reporting. After using Visual Studio, I discovered that the same issue applies to the text controls in Visual Studio, notably WPF.

Description of user facing changes

In Visual Studio, the caret position is no longer sometimes reported inaccurately.

Description of development approach

use a common base class for XAML and WPF editable text.

Testing strategy:

Tested that caret reporting is again accurate in Visual Studio.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@LeonarddeR LeonarddeR marked this pull request as ready for review November 27, 2023 10:53
@LeonarddeR LeonarddeR requested a review from a team as a code owner November 27, 2023 10:53
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Nov 27, 2023
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR

@seanbudd
Copy link
Member

Is this a regression fix? should there be a change log entry?

@LeonarddeR
Copy link
Collaborator Author

LeonarddeR commented Nov 28, 2023 via email

@seanbudd seanbudd merged commit 2190417 into nvaccess:master Nov 28, 2023
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Nov 28, 2023
michaelDCurran added a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants