Fix exception during vertical paragraph navigation #16276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
approved these changes
Mar 8, 2024
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
Closes nvaccess#16274 Summary of the issue: Exception during vertical navigation when one of page items is offscreen. Description of user facing changes N/A Description of development approach Previously I was retrieving x coordinate by calling textInfo.pointAtStart. However it appears that this doesn't work when said textInfo is off screen. Switching to another method: textInfo.NVDAObjectAtStart.location[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16274
Summary of the issue:
Exception during vertical navigation when one of page items is offscreen.
Description of user facing changes
N/A
Description of development approach
Previously I was retrieving
xcoordinate by callingtextInfo.pointAtStart. However it appears that this doesn't work when saidtextInfois off screen.Switching to another method:
textInfo.NVDAObjectAtStart.location[0]Testing strategy:
Passes specified test case.
Known issues with pull request:
N/A
Code Review Checklist: