Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta to master #16291

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Beta to master #16291

merged 7 commits into from
Mar 12, 2024

Commits on Mar 8, 2024

  1. L10n updates for: fi

    From translation svn revision: 78680
    
    Authors:
    Jani Kinnunen <janikinnunen340@gmail.com>
    Isak Sand <isak.sand@gmail.com>
    
    Stats:
    28	20	user_docs/fi/changes.t2t
    24	23	user_docs/fi/userGuide.t2t
     2 files changed, 52 insertions(+), 43 deletions(-)
    NVDA translation automation committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    56e8912 View commit details
    Browse the repository at this point in the history
  2. L10n updates for: fr

    From translation svn revision: 78680
    
    Authors:
    Michel such <michel.such@free.fr>
    Remy Ruiz <remyruiz@gmail.com>
    Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
    Cyrille Bougot <cyrille.bougot2@laposte.net>
    Corentin Bacqué-Cazenave <corentin@progaccess.net>
    Sylvie Duchateau <sylvieduchateau@gmail.com>
    Sof <hellosof@gmail.com>
    
    Stats:
    8	8	user_docs/fr/changes.t2t
     1 file changed, 8 insertions(+), 8 deletions(-)
    NVDA translation automation committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b1af80a View commit details
    Browse the repository at this point in the history
  3. L10n updates for: ja

    From translation svn revision: 78680
    
    Authors:
    Takuya Nishimoto <nishimotz@gmail.com>
    Minako Nonogaki <minakonono3519@gmail.com>
    
    Stats:
    15	1	user_docs/ja/changes.t2t
    4	3	user_docs/ja/userGuide.t2t
     2 files changed, 19 insertions(+), 4 deletions(-)
    NVDA translation automation committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5c9a5ee View commit details
    Browse the repository at this point in the history
  4. L10n updates for: vi

    From translation svn revision: 78680
    
    Authors:
    Dang Hoai Phuc <danghoaiphuc@gmail.com>
    Nguyen Van Dung <dungnv1984@gmail.com>
    
    Stats:
    5	4	user_docs/vi/userGuide.t2t
     1 file changed, 5 insertions(+), 4 deletions(-)
    NVDA translation automation committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    09f5bed View commit details
    Browse the repository at this point in the history
  5. L10n updates for: zh_CN

    From translation svn revision: 78680
    
    Authors:
    vgjh2005@gmail.com
    jiangtiandao901647@gmail.com
    manchen_0528@outlook.com
    dingpengyu06@gmail.com
    singer.mike.zhao@gmail.com
    1872265132@qq.com
    
    Stats:
    333	0	user_docs/zh_CN/changes.t2t
    8	7	user_docs/zh_CN/userGuide.t2t
     2 files changed, 341 insertions(+), 7 deletions(-)
    NVDA translation automation committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a5d1592 View commit details
    Browse the repository at this point in the history
  6. Update translations.

    From translation svn revision: 78680
    NVDA translation automation committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8db90d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. No longer set focused state for accessibility for non focused WX list…

    … items (#16289)
    
    Fixes #16280
    
    Summary of the issue:
    For not fully accessible WX checkable list boxes / list views, NVDA implements custom wx.Accessible class, which exposes proper roles / states. Since WX list boxes have no method to determine if the given item is focused, it was assumed that selected item is always focused. This is not true when the list box itself has no focus. For a long time this was causing only a minor annoyance - when using object navigation to access the not focused list selected item was reported as having focus. With the introduction of tcheckable list into speech settings panel, this is causing the list of available speech modes to receive focus when user changes the synthesizer. It seems that when the controls are re-created Windows notices that the first list item has a focused state, checks that it has no focus and emits a focus event to "correct" this. As to why this is not a problem when creating this panel I guess that controls are created when it is hidden, and focus events are not emitted for non visible windows.
    
    Description of user facing changes
    Selected checkable list items are no longer reported as focused unless they really have focus
    When changing synthesizer from the speech settings panel list of available speech modes no longer gains accessibility focus
    Description of development approach
    Focused state is exposed for selected list box item only when the list box itself is focused. I have tried to use Win32 API to retrieve the real focused items from these controls using LB_GETCARETINDEX for the list box and LVM_GETITEMSTATE for the checkable multi columns list, unfortunately these approaches seem to return index of last focused item even when the parent list no longer has focus.
    lukaszgo1 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a19d299 View commit details
    Browse the repository at this point in the history