Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symbols.dic with fullwidth punctuation symbols #16299

Merged
merged 1 commit into from Mar 14, 2024

Conversation

CyrilleB79
Copy link
Collaborator

Link to issue number:

Closes #16288

Summary of the issue:

Some fullwidth punctuation symbols are not reported when exploring a default regex present in NVDA's own GUI.

Description of user facing changes

The following symbols are reported when navigating character by character or or read at high enough levels of symbol reporting:
.!?:
The way they are reported is now customizable in the symbols dialog.

Description of development approach

Added these symbols in the English symbols file with the following parameters:

  • name: used the Unicode name; no need to use another shorter name since these symbols are not common in English
  • level: same as their western counterpart
  • repetition: same as their western counterpart

These symbols will then be added in other languages symbols files by translators.

For languages commonly using these symbols (e.g. Chinese), translators may find more suitable to use the level / repetition of the western "sentence end" corresponding symbol. E.g. use level / repetition of ". sentence ending" for "dot" instead of "dot" for "fullwidth full stop".

Testing strategy:

Manual tests reading the regex containing them:

  • with eSpeak, OneCore and IBMTTS (similar to Eloquence)
  • reading the line at punctuation levels None and all
  • navigated character by character

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79
Copy link
Collaborator Author

Cc @cary-rowen, @hwf1324, @nishimotz, @josephsl for knowledge of far-east languages.
Note however that the symbol file will be translated and that, as explained in the initial description, punctuation level or repetition may be adapted by translators for the need of each language.

@CyrilleB79
Copy link
Collaborator Author

Also cc @paulber19, author of #16288

@CyrilleB79 CyrilleB79 marked this pull request as ready for review March 13, 2024 10:38
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner March 13, 2024 10:38
@seanbudd seanbudd merged commit bb5e063 into nvaccess:master Mar 14, 2024
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Mar 14, 2024
@CyrilleB79 CyrilleB79 deleted the fullwidthPunctuation branch April 2, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants