Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code of conduct and product vision links in CONTRIBUTING.md #16329

Merged
merged 1 commit into from Mar 22, 2024
Merged

Fix code of conduct and product vision links in CONTRIBUTING.md #16329

merged 1 commit into from Mar 22, 2024

Conversation

gdziadkiewicz
Copy link
Contributor

@gdziadkiewicz gdziadkiewicz commented Mar 22, 2024 •
edited

Link to issue number:

Summary of the issue: The links to COC and product visions in CONTRIBUTING.md are broken. This PR fixes them.

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@gdziadkiewicz gdziadkiewicz marked this pull request as ready for review March 22, 2024 09:34
@gdziadkiewicz gdziadkiewicz requested review from a team as code owners March 22, 2024 09:34
seanbudd
seanbudd approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gdziadkiewicz

@seanbudd seanbudd merged commit 38efb1c into nvaccess:master Mar 22, 2024
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Mar 22, 2024
MatheusExner added a commit to MatheusExner/nvda that referenced this pull request Mar 27, 2024
@MatheusExner
Merge pull request #1 from nvaccess/master
2a3ea0e 
Fix code of conduct and product vision links in CONTRIBUTING.md (nvaccess#16329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanbudd seanbudd seanbudd approved these changes

@Qchristensen Qchristensen Awaiting requested review from Qchristensen Qchristensen is a code owner automatically assigned from nvaccess/userdocs

@michaelDCurran michaelDCurran Awaiting requested review from michaelDCurran michaelDCurran is a code owner automatically assigned from nvaccess/developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2024.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdziadkiewicz @seanbudd @nvaccessAuto