Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the titles of the message windows in the Add-on Store #16339

Merged
merged 1 commit into from Apr 1, 2024

Conversation

CyrilleB79
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

When migrating an add-on update for which the version cannot be compared, the title of the confirmation dialog is "Add-on not compatible"; this is somewhat confusing because the add-on being installed may be compatible.

Description of user facing changes

Changed the title of this dialog with "Install add-on", as it is done for the "Remove add-on" action.

While at it, changed the title of other confirmation dialogs in the add-on store with the action being performed.

Description of development approach

Changed the strings in the code.

Testing strategy:

Manually tested messages

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review March 28, 2024 16:14
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner March 28, 2024 16:14
@michaelDCurran michaelDCurran merged commit 704175b into nvaccess:master Apr 1, 2024
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 1, 2024
@CyrilleB79 CyrilleB79 deleted the msgTitle branch April 3, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants