Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast vertical QuickNav in Gecko-based textInfos #16385

Merged
merged 2 commits into from Apr 15, 2024

Conversation

mltony
Copy link
Contributor

@mltony mltony commented Apr 12, 2024

Link to issue number:

Closes #16382.

Summary of the issue:

Vertical navigation is too slow.

Description of user facing changes

N/A

Description of development approach

Retrieving x coordinate faster in Gecko textInfo by doing a direct IAccessible2 call - as opposed to creating an NVDAObject. According to my rough measurement, this speeds up vertical navigation about 10 times.

Testing strategy:

Tested on usecase provided in the issue above.

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mltony mltony marked this pull request as ready for review April 12, 2024 00:46
@mltony mltony requested a review from a team as a code owner April 12, 2024 00:46
@XLTechie
Copy link
Collaborator

XLTechie commented Apr 12, 2024 via email

@mltony
Copy link
Contributor Author

mltony commented Apr 12, 2024

I don't have any timeout logic in vertical navigation. What I mean by timeout is that some other part of NVDA - I suspect watchdog - prevents scripts from running for too long and interrupts them after 10 seconds. I am not familiar with that logic so don't know whether it's configurable.

@Adriani90
Copy link
Collaborator

How is this suposed to work in Chromium browsers when you use UiA? If this is not gonna work there, we should note that in the user guide or throw a message when people try to navigate vertically while using UIA.
I assume this PR will not have any effect on using vertical nav in MS Word or Outlook. Right? Anyway, I didn't notice performance issues in MS Office, it was only in browsers so far.

@mltony
Copy link
Contributor Author

mltony commented Apr 12, 2024

It still works in edge+UIA - I just tested. Just not as fast.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mltony

@seanbudd seanbudd merged commit 7556a84 into nvaccess:master Apr 15, 2024
1 check was pending
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants