Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when triggering style navigation commands in an empty document #16430

Merged
merged 1 commit into from
May 10, 2024

Conversation

mltony
Copy link
Contributor

@mltony mltony commented Apr 19, 2024

Link to issue number:

Closes #16407

Summary of the issue:

Exception during style navigation command in an empty document

Description of user facing changes

N/A

Description of development approach

Detecting this case and returning early.

Testing strategy:

Tested on use case from the issue.

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mltony mltony marked this pull request as ready for review April 19, 2024 19:42
@mltony mltony requested a review from a team as a code owner April 19, 2024 19:42
@mltony mltony requested a review from seanbudd April 19, 2024 19:42
@mltony mltony changed the base branch from master to beta April 19, 2024 20:10
@seanbudd seanbudd added this to the 2024.2 milestone Apr 21, 2024
@seanbudd
Copy link
Member

The issue reference seems wrong here - is this meant to fix #16405

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 23, 2024
@mltony
Copy link
Contributor Author

mltony commented Apr 23, 2024

No issue reference is correct in the original description. In that issue there's a PDF document made of screenshots, so it indeed appears as an empty document in NVDA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. queued for merge
Projects
None yet
2 participants