-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create special_case_issue.md issue template #16452
Conversation
Co-authored-by: Luke Davis <8139760+XLTechie@users.noreply.github.com>
See test results for failed build of commit 0192d8dede |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads well. Will be interesting to see what issues we get on this template.
This mostly looks good. One small comment I have is regarding line 14 where it says issues may be closed if all required information is not provided. May be this should be fairer to issue submitters, it probably should say that where required information is not provided when requested the issue may be closed. I feel we should make it seem like submitters will be given a chance to provide information they may have accidentally missed from the initial report, either because of a mistake or because they didn't actually know enough to know what may or may not have been important to developers when making the initial issue. |
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 23
Out of diff range and nitpick comments (1)
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md (1)
Line range hint
52-53
: Remove consecutive blank lines.- - +
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 19
Out of diff range and nitpick comments (1)
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md (1)
Line range hint
52-53
: Remove consecutive blank lines.- - +
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Out of diff range and nitpick comments (9)
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md (9)
Line range hint
6-8
: Capitalize "Markdown" as it is a proper noun.- The template uses github markdown, to provide formatting for headings, lists, quotes etc. + The template uses GitHub Markdown, to provide formatting for headings, lists, quotes etc.
Line range hint
32-32
: Separate "however" from the sentence for proper conjunction usage.- however, zip files are allowed, so you can always zip your file and attach that instead. + However, zip files are allowed, so you can always zip your file and attach that instead.
Line range hint
46-46
: Consider a shorter alternative to avoid wordiness.- * Consider swapping to the preview tab in order to read through your issue at any stage to confirm the issue reads as expected. + * Consider using the preview tab to confirm your issue reads as expected.
Line range hint
88-88
: Consider replacing "very important" with a less over-used intensifier.- This section is very important, please be clear and concise. + This section is crucial, please be clear and concise.
Line range hint
125-125
: This word is normally spelled as one.- This section has several sub-sections. + This section has several subsections.
Line range hint
139-139
: Use "about" as an adjective instead of an adverb.- This can be copied from the about option, in the NVDA help menu. + This can be copied from the "About" option, in the NVDA help menu.
Line range hint
171-171
: This word is normally spelled as one.- This section has sub-sections, asking about the basic investigation steps you may have completed. + This section has subsections, asking about the basic investigation steps you may have completed.
Line range hint
189-189
: Insert a comma after "cases" for clarity.- In many cases issues could be caused by an add-on not working correctly or conflicting with other features already integrated in NVDA itself. + In many cases, issues could be caused by an add-on not working correctly or conflicting with other features already integrated in NVDA itself.
Line range hint
197-197
: Consider putting a comma before the abbreviation "i.e.".- COM DLL files, which i.e. the IAccessible COM interface depends on, can get unregistered after installing and uninstalling different programs on a computer. + COM DLL files, which, i.e., the IAccessible COM interface depends on, can get unregistered after installing and uninstalling different programs on a computer.
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
Looks good to me, just one optional suggestion |
Link to issue number:
n/a
Summary of the issue:
NV Access has received feedback from the community that the current issue templates are insufficient to cover all the possible community requests and work that is required on NVDA. In an effort to balance the benefits of using templates with the flexibility required to handle unknown-unknowns, we are creating a new template.
Description of user facing changes
New issue type: Special Case Issue
Description of development approach
Creation of template md file. Update to documentation.
Testing strategy:
n/a
Known issues with pull request:
None
Code Review Checklist:
Summary by CodeRabbit
New Features
Documentation