New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest nvda_dmp #16508
Update to latest nvda_dmp #16508
Conversation
please add a change log entry to 2024.3 in changes.md under changes for developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @codeofdusk
nvda_dmp has received updates for better handling of large diffs, unicode characters, etc. Description of how this pull request fixes the issue: Updates nvda_dmp (and its backing diff-match-patch implementation) to the latest versi
@@ -13,6 +13,7 @@ | |||
|
|||
* Component updates: | |||
* Updated Unicode CLDR to version 45.0. (#16507, @OzancanKaratas) | |||
* Updated fast_diff_match_patch (used to detect changes in terminals and other dynamic content) to version 2.1.0. (#16508, @codeofdusk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but this does not seem to be an update but rather standard diff match patch being replaced by fast diff match patch.
@codeofdusk, is it correct? If yes, the change log item should be modified.
Hi to all,
I would rather want also new formulation in the changelog:
* Improved speed and stability, when the console has been used with
braille displays.
This is particularly visible when there is a new content, and when the
buffer in the console becomes large.
|
@zstanecic |
Hi,
I am not using UIA notification, just for the testing purposes.
|
The change log entry is fine as-is, because:
|
Link to issue number:
None
Summary of the issue:
nvda_dmp has received updates for better handling of large diffs, unicode characters, etc.
Description of how this pull request fixes the issue:
Updates nvda_dmp (and its backing diff-match-patch implementation) to the latest version.
Testing strategy:
Daily testing by two active terminal users.
Known issues with pull request:
None known
Change log entry:
== Changes ==
Code Review Checklist: