Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert 16463 and 16501 #16519

Merged
merged 2 commits into from
May 10, 2024
Merged

revert 16463 and 16501 #16519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1397605
Revert "Fix for dismiss braille message issue of remove redundant bra…
burmancomp May 10, 2024
bc27880
Revert "Remove redundant braille.BrailleHandler.update executions (#1…
burmancomp May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions source/braille.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2560,9 +2560,8 @@ def _doNewObject(self, regions):
self.mainBuffer.update()
# Last region should receive focus.
self.mainBuffer.focus(region)
if isinstance(region, TextInfoRegion):
self.scrollToCursorOrSelection(region)
elif self.buffer is self.mainBuffer:
self.scrollToCursorOrSelection(region)
if self.buffer is self.mainBuffer:
self.update()
elif self.buffer is self.messageBuffer and keyboardHandler.keyCounter>self._keyCountForLastMessage:
self._dismissMessage()
Expand Down Expand Up @@ -2616,10 +2615,8 @@ def _handlePendingUpdate(self):
self.mainBuffer.update()
self.mainBuffer.restoreWindow()
if scrollTo is not None:
if self.buffer is self.messageBuffer:
self._dismissMessage(shouldUpdate=False)
self.scrollToCursorOrSelection(scrollTo)
elif self.buffer is self.mainBuffer:
if self.buffer is self.mainBuffer:
self.update()
elif (
self.buffer is self.messageBuffer
Expand Down