Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userGuide: Modify the Sound split to be consistent with the settings #16547

Merged
merged 3 commits into from
May 17, 2024

Conversation

wmhn1872265132
Copy link
Contributor

@wmhn1872265132 wmhn1872265132 commented May 14, 2024

Link to issue number:

none

Summary of the issue:

  1. The Sound split option is inconsistent with the default value in the user guide.
  2. The order of options in audio settings is inconsistent with the user guide.

Description of user facing changes

Updated user guide

Description of development approach

Updated user guide

Testing strategy:

Read the build documentation

Known issues with pull request:

none

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@wmhn1872265132 wmhn1872265132 requested a review from a team as a code owner May 14, 2024 06:21
@wmhn1872265132 wmhn1872265132 requested review from Qchristensen and removed request for a team May 14, 2024 06:21
@Adriani90
Copy link
Collaborator

This is Already adjusted in #16490. this pr will cause conflict.

@wmhn1872265132
Copy link
Contributor Author

This is a change for the beta branch that will appear in the 2024.2 stable version

@Adriani90
Copy link
Collaborator

Ok, I will fix then the conflict manually in #16490 after this is merged.

@seanbudd seanbudd added this to the 2024.2 milestone May 16, 2024
@seanbudd
Copy link
Member

@mltony - can you share your thoughts on this? My understanding is that the documentation is correct, and the settings are wrong. We should fix the setting to correctly select left/right splitting only by default.

@wmhn1872265132
Copy link
Contributor Author

See #16071 (comment)

@seanbudd seanbudd merged commit 2cb43d7 into nvaccess:beta May 17, 2024
1 check passed
@wmhn1872265132 wmhn1872265132 deleted the SoundSplitUserGuide branch May 17, 2024 03:12
@mltony
Copy link
Contributor

mltony commented May 17, 2024

@seanbudd, this PR makes sense. Sorry for late reply. I updated these setttings because many people were pushing for having a proper disable sound split state. But I forgot to update docs, so this PR fixes that. many

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants