Fix language code for english dev guide #16563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelDCurran
approved these changes
May 19, 2024
seanbudd
added a commit
that referenced
this pull request
May 20, 2024
Fixes #16487 Summary of the issue: currently the lang attribute for the developerGuide has the value "developerGuide": nvaccess.org/files/nvda/releases/2024.1/documentation/developerGuide.html This is because the parent folder name is used to determine the lang code, which is true for other docs. Description of user facing changes Fix lang code for the developer Guide Description of development approach Fix lang code for the developer Guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #16487
Summary of the issue:
currently the lang attribute for the developerGuide has the value "developerGuide": https://www.nvaccess.org/files/nvda/releases/2024.1/documentation/developerGuide.html
This is because the parent folder name is used to determine the lang code, which is true for other docs.
Description of user facing changes
Fix lang code for the developer Guide
Description of development approach
Fix lang code for the developer Guide
Testing strategy:
Perform
scons developerGuideKnown issues with pull request:
None
Code Review Checklist: