New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jab extended keybindings #6082
Conversation
Could that massive control code if tree be converted into a dictionary perhaps in JABHandler? It may offer a slight performance boost, plus it will be more readable in my opinion. Obviously the f1 through f24 keys would not be part of it. |
@rpaquay: Have you addressed the review comment for this? |
This is a change that we would like to accept, however some small modifications need to be made to the code before we can do so. |
@rpaquay are you still available to finalize this work? |
After several attempts to contact the author of this pull request without luck, I'm closing this for now. Note that #6081 is still open, so anyone who suffers from this bug who is able to work on it can easily find this pull request and Revive it. |
@Adriani90 I am not actively working on this project anymore, and I don't have any means to manually verify these changes anymore, but the requested change in the comment is trivial. |
This fix addresses issue #6081.