Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jab extended keybindings #6082

Closed
wants to merge 2 commits into from

Conversation

rpaquay
Copy link
Contributor

@rpaquay rpaquay commented Jun 16, 2016

This fix addresses issue #6081.

@michaelDCurran
Copy link
Member

Could that massive control code if tree be converted into a dictionary perhaps in JABHandler? It may offer a slight performance boost, plus it will be more readable in my opinion. Obviously the f1 through f24 keys would not be part of it.

@LeonarddeR
Copy link
Collaborator

@rpaquay: Have you addressed the review comment for this?

@feerrenrut
Copy link
Contributor

This is a change that we would like to accept, however some small modifications need to be made to the code before we can do so.

@Adriani90
Copy link
Collaborator

@rpaquay are you still available to finalize this work?

@LeonarddeR
Copy link
Collaborator

After several attempts to contact the author of this pull request without luck, I'm closing this for now. Note that #6081 is still open, so anyone who suffers from this bug who is able to work on it can easily find this pull request and Revive it.

@Adriani90
Copy link
Collaborator

@rpaquay, I saw that you commented on some issue recently, but in case you are not able to continue work on this, maybe @kaleev or something else could take this over?
If the work on this can be continued, then please confirm and we can reopen.

@feerrenrut feerrenrut added the Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. label Jun 25, 2020
@rpaquay
Copy link
Contributor Author

rpaquay commented Jun 26, 2020

@Adriani90 I am not actively working on this project anymore, and I don't have any means to manually verify these changes anymore, but the requested change in the comment is trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned requested reports or updates are missing since more than 1 year, author or users are not available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants