Skip blank lines in browse mode, WIP fixes #4904

[derekriemer]

Allow skipping blank lines in browse mode. @jcsteh @michaelDCurran @feerrenrut If possible at some point, can I chat with someone who's familiar with this code to ask how I can implement one last UX fix and see if this approach is scalable?

[derekriemer]

Um, the lines that disagree in config are strange. it looks very much like a white space issue.

[derekriemer]

I can't help but laugh at the fact that my last two commits were about the significance of blank lines, in a PR about omitting them.

[derekriemer]

@michaelDCurran Is it possible in creators yet to get access to the field name, I.E. pre in edge?

[josephsl]

Hi,

Fails in Edge (build 14393). Traceback says:

ERROR - scriptHandler.executeScript (12:43:20):
error executing script: <bound method EdgeHTMLTreeInterceptor.script_moveByLine_forward of <NVDAObjects.UIA.edge.EdgeHTMLTreeInterceptor object at 0x05DAB970>> with gesture u'down arrow'
Traceback (most recent call last):
File "scriptHandler.py", line 187, in executeScript
script(gesture)
File "cursorManager.py", line 233, in script_moveByLine_forward
self._caretMovementScriptHelper(gesture,textInfos.UNIT_LINE,1)
File "cursorManager.py", line 150, in _caretMovementScriptHelper
if self._shouldSkipBlankLines(blankInfo) and self._isBlankHelper(blankInfo):
File "browseMode.py", line 1076, in _shouldSkipBlankLines
controlFields = [field for field in blankInfo.getTextWithFields() if not isinstance(field, basestring) and field.command == "controlStart" and not field.field["isHidden"]]
KeyError: 'isHidden'

This was observed when I visited google.com with Edge and tried to use down arrow to move through lines in browse mode. Thanks.

[derekriemer]

@michaelDCurran Is there a way in edge to get if something is hidden? If not, I'll just remove that check.

[derekriemer]

I could also just do and field.field.get("isHidden", False)

[derekriemer]

@josephsl Can you try again with that change?

[josephsl]

Hi,

Resolved in 14393. I'll get back to you once I run tests in 15063 and in 10586 (Version 1511). Thanks.

[josephsl]

Hi,

Works in builds 10586 and 15063. Thanks.

[michaelDCurran]

tag name is not yet exposed in Edge, though the request has been made. As for hidden: Edge does not include these elements in the tree at all.

[derekriemer]

fixes #4904

[derekriemer]

I'll fix the conflicts and then update the users gui8de (Forgot to)

[derekriemer]

refactoring to put the blank skip code in the move part of the textinfo for a cursor manager, because @jcsteh correctly pointed out that my method doesn't work for braille.

[LeonarddeR]

@derekriemer: Just wondering, how is the refactoring going?

[derekriemer]

haven't had time to work out a new design at all. If you have any ideas, I'm happy to discuss.

[Adriani90]

Hey folks,

this feature would be really really nice. Thank you for your great work.

I hope it does not cause any issues in MS Excel when navigating empty rows in browse mode.

[feerrenrut]

Unless there are any objections, I will close this pull request and suggest that if anyone is interested that they can take over. Thanks @derekriemer for providing the initial implementation!