Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add music symbols to the symbols dictionary #9154

Closed
wants to merge 1 commit into from

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

Fixes #9138

Summary of the issue:

Music symbols, such as ♭ (flat), ♮ (natural) and ♯ (sharp) aren't spoken by NVDA.

Description of how this pull request fixes the issue:

Adds the mentioned symbols to the symbols list.

Testing performed:

Tested by arrowing over the symbols.

Known issues with pull request:

None

Change log entry:

Unicode music symbols (such as natural, flat and sharp) are now spoken appropriately. (#9138)

@tobyrush
Copy link

I'm relatively new to GitHub so I don't know the proper protocol, but would it be possible to include double sharp (𝄪) and double flat (𝄫) as well? The characters are U+1D12A and U+1D12B respectively.

My apologies if this should be posted elsewhere.

@jage9
Copy link
Contributor

jage9 commented Mar 22, 2019

We have a variety of symbols that are not covered by emoji but are still missing. This is one category. We can do this peace meal, or perhaps there is a more comprehensive approach? There are more math symbols missing as well as well as likely other specialized categories.

@LeonarddeR
Copy link
Collaborator Author

I'm going to close this one for now, as first, I believe we need to reach consensus about which symbols belong in to core and how to integrate them properly. It makes sense to add many symbols in one wave, instead of only three or four per pull request.

@shoogle
Copy link

shoogle commented Aug 13, 2020

There's no real need to provide speech for any musical symbols except the ones in this PR and those mentioned in #9158. Accidentals (including doubles) are pretty much the only Unicode music symbols used by actual sheet music software (the remaining symbols come from SMuFL). The basic note symbols see some use in text chat, forums, subtitles for videos (but not in music software since it uses values from SMuFL). No other musical symbols are commonly used by any popular program, musical or otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Natural character Unicode 266e not spoken by NVDA
4 participants