Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing system tests on Appveyor #9358

Merged
merged 4 commits into from Mar 18, 2019

Conversation

Projects
None yet
6 participants
@lukaszgo1
Copy link
Contributor

commented Mar 9, 2019

Link to issue number:

None

Summary of the issue:

With release of PyAutoGUI 0.9.42 the PyScreeze version 0.1.20 is required. Unfortunately it currently doesn't work with Python 2.7 see asweigart/pyscreeze#46
This causes System Tessts to fail when building on AppVeyor.

Description of how this pull request fixes the issue:

When installing dependencies for System tests install PyAutoGUI version 0.9.41

Testing performed:

The build of this PR on AppVeyor passed.

Known issues with pull request:

None

Change log entry:

None needed.

michaelDCurran and others added some commits Mar 4, 2019

@josephsl

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

@lukaszgo1

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

I've created this one as a draft, because I wasn't sure if my approach would really solve the problem. It looks like it works, but I have no idea how to mark it as ready for review.

@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Mar 10, 2019

@lukaszgo1

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

Either I am stupid or this button isn't there. Is it possible that only collaborators can mark pull requests as ready for review?

@@ -120,7 +120,11 @@ build_script:
before_test:
# Manually grab pyscreeze 0.1.13 as latest release is completely broken.
- py -m pip install pyscreeze==0.1.13
- py -m pip install robotframework robotremoteserver pyautogui nose
# The latest release of PyAutoGUI requires PyScreeze 0.1.20 which unfortunately don't work with Python 2.7.

This comment has been minimized.

Copy link
@leonardder

leonardder Mar 12, 2019

Collaborator
Suggested change
# The latest release of PyAutoGUI requires PyScreeze 0.1.20 which unfortunately don't work with Python 2.7.
# The latest release of PyAutoGUI requires PyScreeze 0.1.20 which unfortunately doesn't work with Python 2.7.
@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Mar 12, 2019

Could you please change the base branch to beta?

@lukaszgo1 lukaszgo1 marked this pull request as ready for review Mar 12, 2019

@lukaszgo1 lukaszgo1 changed the base branch from master to beta Mar 12, 2019

@lukaszgo1

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

@leonardder All your commends are now addressed.

@leonardder

This comment has been minimized.

Copy link
Collaborator

commented Mar 12, 2019

@dingpengyu

This comment has been minimized.

Copy link

commented Mar 13, 2019

hi leonardder
A few days ago Python officially released a maintenance version of python2x, python2.7.16, NVDA will upgrade python2x to the latest?

@michaelDCurran michaelDCurran merged commit 29e901b into nvaccess:beta Mar 18, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Mar 18, 2019

leonardder added a commit that referenced this pull request Mar 28, 2019

Fix failing system tests on Appveyor (#9358)
* Fix failing system tests on Appveyor

* Fix capitalization

* Review actions

leonardder added a commit that referenced this pull request Mar 28, 2019

Fix failing system tests on Appveyor (#9358)
* Fix failing system tests on Appveyor

* Fix capitalization

* Review actions

@lukaszgo1 lukaszgo1 deleted the lukaszgo1:FixSystemTestsOnAppveyor branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.