Fix failing system tests on Appveyor #9358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I see, this explains a lot. CC @LeonarddeR
From: Łukasz Golonka <notifications@github.com>
Sent: Saturday, March 9, 2019 12:15 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [nvaccess/nvda] Fix failing system tests on Appveyor (#9358)
Link to issue number:
None
Summary of the issue:
With release of PyAutoGUI 0.9.42 the PyScreeze version 0.1.20 is required. Unfortunately it currently doesn't work with Python 2.7 see asweigart/pyscreeze#46 <asweigart/pyscreeze#46>
This causes System Tessts to fail when building on AppVeyor.
Description of how this pull request fixes the issue:
When installing dependencies for System tests install PyAutoGUI version 0.9.41
Testing performed:
TBD
Known issues with pull request:
None
Change log entry:
None needed.
…_____
You can view, comment on, or merge this pull request online at:
#9358
Commit Summary
* Fix failing system tests on Appveyor
* Fix capitalization
File Changes
* M appveyor.yml <https://github.com/nvaccess/nvda/pull/9358/files#diff-0> (6)
Patch Links:
* https://github.com/nvaccess/nvda/pull/9358.patch
* https://github.com/nvaccess/nvda/pull/9358.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9358> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkLx8n2GGcSJIeG2PwiGkr8tJ-WVoks5vVBZcgaJpZM4bm4Z1> .
|
|
I've created this one as a draft, because I wasn't sure if my approach would really solve the problem. It looks like it works, but I have no idea how to mark it as ready for review. |
|
There must be a button for that, around the place where the merge button is situated. I believe just above the new comment area.
|
|
Either I am stupid or this button isn't there. Is it possible that only collaborators can mark pull requests as ready for review? |
LeonarddeR
reviewed
Mar 12, 2019
appveyor.yml
Outdated
| @@ -120,7 +120,11 @@ build_script: | |||
| before_test: | |||
| # Manually grab pyscreeze 0.1.13 as latest release is completely broken. | |||
| - py -m pip install pyscreeze==0.1.13 | |||
| - py -m pip install robotframework robotremoteserver pyautogui nose | |||
| # The latest release of PyAutoGUI requires PyScreeze 0.1.20 which unfortunately don't work with Python 2.7. | |||
There was a problem hiding this comment.
Suggested change
| # The latest release of PyAutoGUI requires PyScreeze 0.1.20 which unfortunately don't work with Python 2.7. | |
| # The latest release of PyAutoGUI requires PyScreeze 0.1.20 which unfortunately doesn't work with Python 2.7. |
|
Could you please change the base branch to beta? |
|
@LeonarddeR All your commends are now addressed. |
|
Feel free to mark this ready for review. Note that an NV Access developer will have to merge this into master.
|
|
hi leonardder |
michaelDCurran
approved these changes
Mar 18, 2019
LeonarddeR
pushed a commit
that referenced
this pull request
Mar 28, 2019
* Fix failing system tests on Appveyor * Fix capitalization * Review actions
LeonarddeR
pushed a commit
that referenced
this pull request
Mar 28, 2019
* Fix failing system tests on Appveyor * Fix capitalization * Review actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
With release of PyAutoGUI 0.9.42 the PyScreeze version 0.1.20 is required. Unfortunately it currently doesn't work with Python 2.7 see asweigart/pyscreeze#46
This causes System Tessts to fail when building on AppVeyor.
Description of how this pull request fixes the issue:
When installing dependencies for System tests install PyAutoGUI version 0.9.41
Testing performed:
The build of this PR on AppVeyor passed.
Known issues with pull request:
None
Change log entry:
None needed.