Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global commands: restore commands affected by division operator differences between Python 2 and 3 #9748

Merged
merged 2 commits into from Jun 15, 2019
Merged

Global commands: restore commands affected by division operator differences between Python 2 and 3 #9748

merged 2 commits into from Jun 15, 2019

Commits on Jun 15, 2019

  1. Global commands/mouse to navigator object: use two slashes to guarant… 

    …ee integers for mouse coordinates. Re nvaccess#9641.

Move mouse to navigator object command fails in Python 3 because of ytpe differences: user32::SetCursorPos wants integers, but because one slash is used, it'll get floats, causing errors to be logged. Thus guarantee inteers via floor division, thus restoring the said command.
    @josephsl
    josephsl committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    365caf5 View commit details
    Browse the repository at this point in the history

  2. Global commands/battery status: hours and minutes must be integers. Re … 

    …nvaccess#9641.

With just one slash, hours nad minutes for remaining time on battery will get floats when the text format specifies integers. Thus use floor division, restoring battery status command in Python 3.
    @josephsl
    josephsl committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    6323548 View commit details
    Browse the repository at this point in the history