Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Values Wrong in Table #4

Closed
cliffgold opened this issue Nov 3, 2017 · 2 comments
Closed

Address Values Wrong in Table #4

cliffgold opened this issue Nov 3, 2017 · 2 comments

Comments

@cliffgold
Copy link
Contributor

cliffgold commented Nov 3, 2017 •
edited
Loading

I think the Addresses in the hwarch.rst do not agree with the code. Table 10 looks mostly correct, except a couple of end addresses. But tables 11-30 have an extra 0x3000 added.

Added as pull request.
@cliffgold cliffgold mentioned this issue Nov 3, 2017
Closed
@jwise
Copy link
Contributor

jwise commented Nov 18, 2017 •
edited
Loading

Also, as noted in nvdla/nvdla.github.io#1, looks like the CVIF offsets are wrong (which you have fixed -- thanks!). Poked the reviewer for this.

@jwise jwise mentioned this issue Nov 18, 2017
Closed
@jwise
Copy link
Contributor

jwise commented Nov 28, 2017

Fixed in 86fc48d.

@jwise jwise closed this as completed Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwise @cliffgold