Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering in link partial (need help) #4

Closed
nvh95 opened this issue Oct 27, 2022 · 1 comment · Fixed by #5
Closed

Flickering in link partial (need help) #4

nvh95 opened this issue Oct 27, 2022 · 1 comment · Fixed by #5
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nvh95
Copy link
Owner

nvh95 commented Oct 27, 2022

Describe the bug

The link partial gets flickering when visiting https://cv.hung.dev

Reason:

  • nuxt/ vue-notion need to recompute inline CSS to layout link partial. So, when JS is loaded, the UI will look as expected

Screenshots

Oct-27-2022 11-27-36

Reproduce

Just visit https://cv.hung.dev

Expected behavior

UI should remain the same with or without Javascript

Additional context

We might need to update the notion content, which is at https://hung.dev/cv (I am not sure how). But I prefer if we can resolve it by code itself

@nvh95 nvh95 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Oct 27, 2022
@huyng12
Copy link
Contributor

huyng12 commented Oct 29, 2022

Take a look at the implementation of Column block here.

You can see that the it is wrapped by Fragment component from vue-fragment which is not support SSR because of its idea. TLDR; It will render a div to wrap elements, then remove them on loaded. So that, DOM structure would be wrong in the first load (aka SSR).

I have an idea to work around that is override their styles to make its visual before/after loaded stay the same.

Check out my PR's changes for the implementation.

@nvh95 nvh95 closed this as completed in #5 Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants