plog changes for different .netrc directory and use FS version #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehorsley
reviewed
Apr 29, 2020
|
👍 looks good. I'm curious why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a need to get .netrc out of user's home directories for security and curl in Stretch makes that possible. I made a draft version that allows a different directory to be set with an environment variable, I tried to use the style of @dehorsley, but no doubt did not get all the nuances. Similarly while I was there I made a draft removal of the plog self versioning, as had been done for fesh. However, I did not see immediately where the best place was to print the version number before getting to work as is done in fesh now. Please amend as you see fit.