Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbi.stackup doesn't error with intervals of different lengths #22

Closed
Snehal1894 opened this issue Nov 14, 2022 · 3 comments
Closed

bbi.stackup doesn't error with intervals of different lengths #22

Snehal1894 opened this issue Nov 14, 2022 · 3 comments

Comments

@Snehal1894
Copy link

I used bbi.stackup fuction with varying intervals and it gave me valid a 2D numpy array without throwing any error, when it mentioned that it works with equal intervals.

@nvictus
Copy link
Owner

nvictus commented May 27, 2023

Thanks. I actually dropped this requirement a while ago, but it looks like the docstring wasn't updated to reflect it. Specifically, if the bins= argument is used, the intervals can have any length, since each interval can be rescaled to the same number of bins.

It's actually a feature rather than a bug (e.g. to rescale genes to a standardized length), but maybe there should be some guardrails to prevent this from accidentally happening when one thinks that one's intervals all have the same length.

@nvictus
Copy link
Owner

nvictus commented May 27, 2023

Behavior is clarified in the docstring in #28.

@nvictus nvictus closed this as completed May 27, 2023
@dmitrymyl
Copy link

Hello! That's a nice feature of interpolating a signal. Could you please also add this clarification to the repo's Readme? Some users usually refer to that rather than to docstrings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants